code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.54k stars 542 forks source link

max width within page broken + weird halo on old alternative #1892

Open alidan opened 11 months ago

alidan commented 11 months ago

Bug Report:

BUG:
chrome_2KcMj6qrlU

this is a 16:9 video, as you can see, borders on everything ⚬ HOW: I think just use that setting wHoxR97AVb

⚬ ImprovedTube Version: 4.506

the fix currently is going to old alturnative fit to window, and I would say this is a pemanent fix, but it has a weird halo chrome_Ix4V1wpG6b chrome_4kM4laYiyU

if you need anything more form me, ill see what I can do. if there is a fix to either of these I can implement with a user script, will gladly do that for the time being.

ImprovedTube commented 11 months ago

hi! @alidan, couldn't reproduce your first screen. but its relevant and was our first popular feature. While generally fixing such will not always take longer than finding an alternative (and sometimes avoiding averse effects) - yet if you / we can fix something here, a high number of users may appreciate it (overproportionally rewarding, totally crazy (awesome))

for example https://github.com/Zren/ResizeYoutubePlayerToWindowSize is providing such userscript (updated & with MIT license even♡) - hi @Zren! #1881.

halo

do you mean YouTube's 'ambiente light' existing since 2022 and called cinematics?:

https://github.com/search?q=repo%3Acode-charity%2Fyoutube%20cinematics&type=code

user script

.. but not extensions?

alidan commented 11 months ago

I just tried it incognito, and its a bit more broken there then it is in my image chrome_xFKB6HYM3q

The script fixed it, thanks

as for what's normal with youtube I have no idea, I have used this extension for years,

and as for why userscripts, I believe there were other things where scripts fixed whatever youtube decided to do faster than the extension updated. either way, problem sidestepped for the moment.

ImprovedTube commented 11 months ago

sidestepped for the moment.

not here, if anybody else gets the errors too... (while i cant tell right now if it is most% or few% of our users getting this, both is enough to care... (next to caring about some other bugs. whew)