Repeat stuck on

[ToughSun14]

Bug Report:

⚬ BUG: No matter what settings I adjust, whenever this extension is active, repeat is always set to on when I load a video ⚬ HOW: (unclear, this bug just appeared one day all of a sudden) ⚬ If a YouTube change started the bug, please copy the DOM you get (especially if the bug doesn't happen when you log out or on another computer) ⚬ Or did our last update start the bug? <-- Possibly... ⚬ ImprovedTube Version: 4.641

⚬ Screenshots:
/ ⚬ Context: Yesterday, I was running YouTube without any issues with this extension on. Now I wake up this morning and find out that no matter what settings I adjust, when this extension is active it automatically enables looping for any video I load up. / ⚬ Expected /preferred behavior: ⚬ Browser: Opera GX core: 106.0.4998.76, Chromium version:120.0.6099.217 ⚬ Settings:

⚬ OS: Windows 11 ⚬ Device: Alienware M18 R1

[Jerrk]

I started to notice this issue today as well.

turning off the extension fixes the issue.

[Rat-bags]

yes I have also have this issue and its very annoying, and can confirm disabling the extension fixes the loop always on

[meechgalhuquot]

Can confirm I have this issue as well, it still happens even if I completely reset the extensions settings

[WilliumBobCole]

Signed up for github to say I noticed this behaviour this morning

edit: it also seems to be messing with my preference to stop autoplay upon loading a tab, it's kinda inconsistent and IDK if this is at all related to this issue, I'm just hoping that a fix for the unwanted looping will also fix this unwanted autoplaying...

[ImprovedTube]

hi, fix should be obvious / quick.
thanks for caring @ToughSun14 @Jerrk @meechgalhuquot @Rat-bags

autoplay

, which didnt start at once, just now? @WilliumBobCole

[ImprovedTube]

hopefully the stores release this soon (might not on sunday).

[Rat-bags]

Thank you so much, this is driving me nuts, also has anyone reported the auto hide the side scroll bar not hiding anymore on video page?

[ImprovedTube]

btw! if you didnt re-install, do you guys see this? or rather: how how many days in the past is this frame stuck?

(Browsers seem to cling to caching iframes too much since many years)

---

@Rat-bags general:scrollbar:hidden? it doesnt work in Chrome nor Firefox surprisingly. Since when? it is very old and simple (maybe browsers stopped allowing this? Or else asking chatgpt or stackoverflow it might be efficient to enter our contributor list & become the hero of this feature) https://github.com/code-charity/youtube/blob/9d1d6cd9bb7f5f834a1f55cef3a373f85778879a/js%26css/extension/www.youtube.com/general/general.css#L154-L155

[Rat-bags]

i don't see that no the last we see in list is date 16th show upload date

as for the scrollbar hide that has broken 3-4 weeks and i have found a workaround to make work and that is in the chrome flags and enable Overlay Scrollbars (#overlay-scrollbars) that will then hide the scrollbars again

[Djotta11]

it keeps looping the ads wth

[ImprovedTube]

@Rat-bags 👍 just in case that turns out to be the only way, we can still add a link/tooltip to chrome://flags/#overlay-scrollbars (and other browser's equivalents) to respect that people remember the place of our feature.

[ImprovedTube]

all we can do is watch the reinstalls/uninstalls until chrome webstore reviewed the fix. @Djotta11

https://improvedtube.com/uninstalls-hours-days-usatime-updated-every-3-minutes

(unfortunately, besides that it is sunday, by experience they might also take longer for small fixes than big updates, if the small fix comes right after the big update. dont know why)

[ImprovedTube]

more importantly, unfortunately there is no Crome Web Store feature, to just let us publish a previously approved version.

(Firefox has this )

[Rat-bags]

@ImprovedTube I just want to say thank you again for taking your sunday and spending it doing fix and updates and today's bugs have given me a chance to look through all the new options and features you have implemented since last looking months ago, so again I thank you for this amazing extension that most of us couldn't live without

[Rat-bags]

Can confirm the 'Improve YouTube!' TESTING version has updated to 4.642 and the fix works for repeat/loop always on

[ImprovedTube]

[GKid94]

Same problem 4.641 version

[Jerrk]

The update is now installed for me and the issue resolved

[LPChip]

I have version 4.642 and the problem is still there. Stuck on loop on. Even if I turn it off, its on again on next video.

[LPChip]

I've turned off this extension and got Enhancer for YouTube, and the issue is not there.

EDIT: I gave it one more try, and this time it did work. I have no idea why it did not work before. It seems like the extension showed as the new version, but what was applied was cached. It took turning the extension off, reload youtube, and on to fix it, apparently.

The loop button inside the video is gone now though, despite it being on, and the one below the video can reappear after turning that setting off and on. I have a feeling cache caused the video player button to show, and if it is visible, it doesn't work. The Enahancer may have done something too, I dunno.

[Anoaxx]

I know its a long convo, but even reinstalling didnt help? Trust me, it happens sometimes that option got stuck.

[ToughSun14]

Well, the loop always on bug has been fixed, but now there's a new issue: the repeat button doesn't turn bright white when it's clicked. Instead it only toggles between gray and dark gray.

[LPChip]

Okay, I completely take back what I said. It appeared to have been fixed, but I just watched another video. The loop button was back in the inlay video and was turned on, and right-clicking the video shows that loop status is also turned on.

This is definitely NOT fixed. Am going back to Enhanced YouTube plugin, and follow this topic to see when it really is fixed.

[ImprovedTube]

@ToughSun14 noticed & fixed. Was a side-effect of an edit to sync the transparency of both buttons (just in case somebody uses both buttons)

Trust me, it happens sometimes that option got stuck.

then you might be on to a bug with the browser? (what about other extensions?) Toggling the switch doesnt work then? @Anoaxx

@LPChip Do you have youtube tabs still in ram since sunday? (=still running our previous version). Does youtube ever remember loop state by video?

all we can do is watch the reinstalls/uninstalls until chrome webstore reviewed the fix. @Djotta11

https://improvedtube.com/uninstalls-hours-days-usatime-updated-every-3-minutes

(unfortunately, besides that it is sunday, by experience they might also take longer for small fixes than big updates, if the small fix comes right after the big update. dont know why)

you can see the uninstalls are normal again, the extra few normally happen after a bug was fixed. (Of course there is room to speculate if another bug still happens to few % of users, and If so, that might be unrelated.) (Yet confusing experiences are also a common reason. No offence, just statistics).
This is a free service since 2012. We not make every second productive threads about Enhancer. Open source developers might enjoy to use their head uniquely.

[LPChip]

@ToughSun14 noticed & fixed. Was a side-effect of an edit to sync the transparency of both buttons (just in case somebody uses both buttons)

Trust me, it happens sometimes that option got stuck.

then you might be on to a bug with the browser? (what about other extensions?) Toggling the switch doesnt work then? @Anoaxx

@LPChip Do you have youtube tabs still in ram since sunday? (=still running our previous version). Does youtube ever remember loop state by video?

all we can do is watch the reinstalls/uninstalls until chrome webstore reviewed the fix. @Djotta11

https://improvedtube.com/uninstalls-hours-days-usatime-updated-every-3-minutes

(unfortunately, besides that it is sunday, by experience they might also take longer for small fixes than big updates, if the small fix comes right after the big update. dont know why)

you can see the uninstalls are normal again, the extra few normally happen after a bug was fixed. (Of course there is room to speculate if another bug still happens to few % of users, and If so, that might be unrelated.) (Yet confusing experiences are also a common reason. No offence, just statistics). This is a free service since 2012. We not make every second productive threads about Enhancer. Open source developers might enjoy to use their head uniquely.

That's a good question. I may have from before it got updated on my end. I'll close and reopen the browser and see if that fixes it, and for how long. I kept reusing the same tab though and it was fixed in that tab and then got back in that tab, so not sure what is the problem. I'm using Vivaldi browser btw, if that helps.

[LPChip]

Restarted the browser, disabled the Enhance Youtube plugin, enabled the Improve Youtube plugin, went to settings but did not change anything, clicked a video, the loop button was visible and turned on. Right-clicked the video, loop is checked.

Interestingly, if I refresh the page, the loop button is gone and loop is not enabled either. So its probably a combination of these: There's still a bug present and I do something that triggers it in my testing that others have not done.

If I click youtube logo, then a video, the loop button is visible and its looped again.

EDIT: If I refresh, the entire plugin does not seem to load because all buttons are gone too.

[LPChip]

Okay, I figured it out. And I kinda feel dumb now.

But I blame lack of explanation.

In the settings, Player, there is the section for buttons. Repeat and Always on. Both have a slider. I did not realize that they are actually separate things. If you enable the top one, it shows the button, if you enable the bottom one, it always puts repeat on. I wanted to see the button because there are occasions when I want to loop a video, so I had both enabled.

Apparently, I only want the top one enabled, and that seems to fix the issue.

[ImprovedTube]

hi! @LPCHip you can enhance the language "always active" "always enabled" "always repeat (loop) every video" in the english language file.

And/or a special style - or an animation triggered only the moment the toggle is enabled. https://github.com/code-charity/youtube/blob/727f824c5ae31375e7038fdc80a40aa5136fac41/menu/styles/sub-options.css#L58

[LPChip]

hi! @LPChip you can enhance the language "always active" "always enabled" "always repeat (loop) every video" in the english language file.

And/or a special style - or an animation triggered only the moment the toggle is enabled.

https://github.com/code-charity/youtube/blob/727f824c5ae31375e7038fdc80a40aa5136fac41/menu/styles/sub-options.css#L58

I'm sorry, I don't know how that works. But my suggestion would be: "force button state to on" (or remove the word to if too long)

[Anoaxx]

then you might be on to a bug with the browser? (what about other extensions?) Toggling the switch doesnt work then? @Anoaxx

Its an issue i have with that extension for years, and had it on a Chrome, and now on Opera GX, so its still chrominium? tbh idk why its happenin, reinstaling usually works.

[ImprovedTube]

I'm sorry, I don't know how that works. But my suggestion would be: "force button state to on" (or remove the word to if too long)

the feature works alone with out the button. So "always repeat (loop) every video" is accurate description. the referred line of CSS is what makes it show indented. So you could remove it and/or we can replace it with an animation /"warning

[raszpl]

https://github.com/code-charity/youtube/commit/dd59c16f96360ce06d466e908290cf3aef77cf4d overreacted and broke display of player_always_repeat even when player_repeat_button is not active

solution is to change https://github.com/code-charity/youtube/blob/967ccbb8138f2ba2f2dcefc349d040e7000391a1/js%26css/web-accessible/functions.js#L300 and https://github.com/code-charity/youtube/blob/967ccbb8138f2ba2f2dcefc349d040e7000391a1/js%26css/web-accessible/functions.js#L357 to always check both are active if (this.storage.player_repeat_button === true && this.storage.player_always_repeat === true) {ImprovedTube.playerRepeat();};

implemented in https://github.com/code-charity/youtube/pull/2085 Ideally https://github.com/code-charity/youtube/blob/967ccbb8138f2ba2f2dcefc349d040e7000391a1/_locales/en/messages.json#L48 should be changed to "playerForceRepeat":{"message":" Force Always Repeat"}, for all language Locales to make it more clear what it does and help find it using build in search. Edit: oh great, there is also improvedtubeYoutubeButtonsUnderPlayer below_player_loop to take care of

[ImprovedTube]

hi! @raszpl, sorry, i think i should have closed this earlier,
since your attention is worth solving the most critical things. (and this wasn't a bug anymore) ( label:bug sort:comments-desc is:open must be best, IF long threads weren't overwhelming)

the always-repeat function was made a repeat-function, as it is more minimal. A function more likely to be repurposed (in theory. For example a feature could enable loop automatically once manually playing the video for 200 or 300 of the time, going back repeatedly)

display of player_always_repeat even when player_repeat_button is not active

while previously it was conditionally shown to avoid somebody forgetting the feature, now it is possible to use it without showing any buttons on youtube. The switch remains nested in the popup to make sure it makes sense to humans and is clear that it is a very specific thing
( and it is linguistically efficient not to print the word "repeat" twice, nor translate another specific string consuming more pixels, otherwise:

"always repeat (loop) every video" is accurate description.

)

---

Edit: oh great, there is also improvedtubeYoutubeButtonsUnderPlayer below_player_loop to take care of

yes, with synced opacity, just in case somebody uses both

---

since your attention is worth solving the most critical things.

..and i think the next thing i should write is a dashboard with live-data, what switches are currently toggled the most (or other clues about bugs and UI)

[raszpl]

while previously it was conditionally shown to avoid somebody forgetting the feature, now it is possible to use it without showing any buttons on youtube.

This is bad UI design, users wont know its turned on and complain like they did here in this bug.

it is linguistically efficient not to print the word "repeat" twice, nor translate another specific string consuming more pixels,

it might look nice, but breaks search

Edit: oh great, there is also improvedtubeYoutubeButtonsUnderPlayer below_player_loop to take care of

yes, with synced opacity, just in case somebody uses both

afair not synced with settings. I rewrote it, but havent tested extensively yet.

btw the PR has if this.storage.player_always_repeat || (without === true)

Because its tautology. What values can this.storage.player_always_repeat have?

[ImprovedTube]

This is bad UI design, users wont know its turned on and complain like they did here in this bug.

like i wondered years ago besides many of our features are set permanently

it might look nice, but breaks search

right🤔 i guess search can consider tags, header or pathes in future