search

code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.4k stars 513 forks source link

Remove our text <input></input> limits (Max playback speed or max volume need not be limited) #2028

Open klimchd opened 6 months ago

klimchd commented 6 months ago

Bug Report:

⚬ BUG: Max playback speed is limited by 2.75. I'm using 3-3.5x, would be good to restore the limit to the previous 4x ⚬ HOW: Settings -> Player -> Playback speed (the max value of the slider is 2.75)

⚬ Fix: Should be fixable just by changing the value "2.77" back to 4 here

Amrani-Farouk-Hossam-Eddine commented 6 months ago

Hi, i want to fix it if it doesn't been fixed

ImprovedTube commented 6 months ago

hi! @klimchd beyond 2.77 doesnt sound healthy! / dont want to feel involved with that. / What about using the input field for experiments

klimchd commented 6 months ago

@ImprovedTube I was using 3+x for years and everything fine, no worries! :)

Currently the input field also limited by 2.75 (auto corrects to this value). I would be happy to use only the input, no need to extend the slider. Probably, not that many people use such high speed, but it doesn't hurt anyone to have this option accessible.

khushi89012 commented 6 months ago

Hi, i want to fix it if it doesn't been fixed

Anoaxx commented 6 months ago

@ImprovedTube I was using 3+x for years and everything fine, no worries! :)

Currently the input field also limited by 2.75 (auto corrects to this value). I would be happy to use only the input, no need to extend the slider. Probably, not that many people use such high speed, but it doesn't hurt anyone to have this option accessible.

tbh default max is 2.75 but u can easly expand that with shortcuts!

klimchd commented 6 months ago

@Anoaxx Thanks for the tip! I can at least use the shortcuts for now. But it works only for current video, it's nice to have the default speed for any video.

ImprovedTube commented 6 months ago

so it overwrote your current setting? @klimchd can be max. 3.5 for now, just for you :D

tbh

my bad, thinking you can enter any number. We can fix our text inputs already. And then ask again whats a reasonable max. for the slider for most users?

klimchd commented 6 months ago

@ImprovedTube I will be happy if the input would accept any number, thank you!

Also fixed it for now in my local copy of the extension. Of course it will be overwritten with the next update.

ImprovedTube commented 5 months ago

bump!

hi, @klimchd (sorry for the further delay.) Did you still feel patronized by the 3.17 or fair-enough? 🤣 i'm not yet intentionally taking many big opportunities to push moderation. Just wondering if maybe this one was worth the 2 negative reviews so far (if that's all on the downside.) So you may participate in today's definition of speed-watching.
(Unless you guys already have a global ladder, like sports and medical long term studies.)

klimchd commented 4 months ago

bump!

hi, @klimchd (sorry for the further delay.) Did you still feel patronized by the 3.17 or fair-enough? 🤣 i'm not yet intentionally taking many big opportunities to push moderation. Just wondering if maybe this one was worth the 2 negative reviews so far (if that's all on the downside.) So you may participate in today's definition of speed-watching. (Unless you guys already have a global ladder, like sports and medical long term studies.)

Thanks for the reply! 3.17 is better, enough as a default. Usually, bumping it up by 0.25-0.5 using the hotkeys. Still, would be nice to be able to set it with UI, no pressure, of course :)

I notice another issue with speed not applied properly: the speed setting of the extension is not applied and video plays with YouTube default (i.e. 2.0x). It occurs randomly and usually fixed with page reload (sometimes it takes several times). The hotkeys also change speed only up to 2.0. It feels like some part of the script is not loaded/executed. Pretty sure such issue already exists in the backlog.

ImprovedTube commented 4 months ago

hi!! @klimchd

I notice another issue with speed not applied properly: the speed setting of the extension is not applied and video plays with YouTube default (i.e. 2.0x). It occurs randomly and usually fixed with page reload (sometimes it takes several times). The hotkeys also change speed only up to 2.0. It feels like some part of the script is not loaded/executed. Pretty sure such issue already exists in the backlog.

how often? please check F12 > console then, and can you tell since when? (x month?)

maybe sometimes only youtube's settings are available and the universal way to set speed for the HTMLMediaElement fails? also

(sometimes it takes several times).

so it is rare but sticky?

youtube might remembers the speed per video? (when set manually?) Our function tries to respects that assuming, that any speed that is already there was set manually.

klimchd commented 4 months ago

@ImprovedTube It feels like the issue was here forever. Sometimes it appear less frequently, sometimes more. I think at least 6-12 months.

When issue appears, pressing the speedup hotkey will result in "2x" at the top-center image Normally, the speed changed with the extension shows in the top-right corner: image

Tried to reproduce it:

ImprovedTube commented 4 months ago

Tried to reproduce it:

  • happens when the video opens for the first time.

  • reloading the page usually fixes

  • (how often?)

  • the error "requestStorageAccessFor: Permission denied." always shows up in the console.

thanks!

and it says about manually set speed to 2

which wasn't true and played at your 3x?

I think at least 6-12 months.

can remember more?

the same standard "2x" label appears at the center (though the speed still at 16x)

👍 (btw🤫Not all browsers have the limit of 16x)

klimchd commented 4 months ago
  • (how often?)

Looks like the reload fixes it every time.

which wasn't true and played at your 3x?

No, it seems to be playing at 2x. But I can change it by slider in the extension popup to 3x and then the hotkeys value 2x is invalid.

can remember more?

No, sorry. I think speed up was broken completely (probably even sereral times) and after the fix it started working somewhat unreliably. But I really can't remember the timeline.

It's the same issue with hotkeys not working as https://github.com/code-charity/youtube/issues/2166

I notice two issues with default hotkeys:

  1. The default hotkeys for speed are < and > image That's contradicts to the default YouTube hotkeys Shift+> for increase and Shift+< for decrease.

  2. I can't trigger the default hotkeys < and > (without Shift), on my keyboard/layout it would be , and . Is there a popular layout that allows to enter < > without Shift?

the same standard "2x" label appears at the center (though the speed still at 16x)

👍 (btw🤫Not all browsers have the limit of 16x)

Tested Chrome, Opera and Edge the limit is 16 on these. It showing "2x" label just because I had the same shortcut as default YouTube (i.e. Shift+>). So when the extension fails to process the shorcut, the default YouTube takes over and processes it showing "2x".

ImprovedTube commented 3 months ago

hi! @klimchd, thanks frequency of the bug will be good to know still.
( Unfortunately the error doesn't refer to our scripts, but youtube's )

hopefully it will can be fixed when we re-evaluated the timing of some of our functions. while other bug report are even harder to imagine: https://github.com/code-charity/youtube/issues/2175

Is there a popular layout that allows to enter < > without Shift?

QWERTY

16

firefox is unlimited😅

colinstu12 commented 2 months ago

What happened to the max speed? I swear it used to do 4x, maybe even faster. Now it's limited to only 3.17x? I usually just stick to 2x for most content, but some content is extremely slow (not timelapsed at all, and it's of a build of stuff, so I'd much prefer crank it faster).

klimchd commented 2 months ago

About a month ago I switched to another extension purely for speed control. It has one huge benefit - works on every video, not only Youtube. Of course, using ImprovedTube for layout and other stuff.