code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.44k stars 522 forks source link

720p forced 16:9 aspect ratio not working anymore #2033

Open Paahtomarakatti opened 7 months ago

Paahtomarakatti commented 7 months ago

Bug Report:

BUG: Since the new update 720p aka 16:9 aspect ratio for the site doesn't work anymore ⚬ HOW: Update perhaps? Lubetube 720p setting before update Lubetube 720p setting after update . ⚬ If a YouTube change started the bug, please copy the DOM you get (especially if the bug doesn't happen when you log out or on another computer) ⚬ Or did our last update start the bug? I think it's the most recent Improve YouTube! update, since i didn't have this bug yesterday. ⚬ ImprovedTube Version: General 4.642

1. Thanks for coming & caring! Before submitting, please check if the issue has already been reported ever. With GitHub's issue search (use this link) (else removing "is:issue is:open" from the standard search) ( - If it was posted before, you can answer/react there to give it your voice and move it up in the lists) ( - If the status is "closed" (=fixed) recently, then Web Stores can be updated soon - if it was closed month or years ago, then it might reappeared & must be fixed again.)

2. To give us a chance to solve the bug: Can you ...?:


More / optionally:

Screenshots:
/ ⚬ Context: The video title, player width and recommended videos are fitted to more wider area. Disabling the addon gets rid of the ultra wide bug, but it also returns youtube to the default youtube player mode, which in this case means 4:3 for the video in question. Also tried disabling other addons and tried incognito mode aswell, no success. Only disabling Improved YouTube! fixed it but then youtube forces it's own aspect ratios on videos, which i'm not personally fan of, i would like the site to remain in 16:9 and the player aswell. Like it did with the 720p player size setting, also the weird gray bar on the top happened in some of the videos aswell and fixes itself when F5/refresh is done but it also means the player will go ultrawide mode (i also use 90% zoom on the site, but changing to 80% or 100% still didn't fix it.) P.S. Not exactly sure how to import "DOM". / ⚬ Expected /preferred behavior: 720p aspect ratio setting (not the video quality) used to force the site to be like in the first picture aka 16:9, with more white space at the sides. ⚬ Browser: Google Chrome Version 121.0.6167.185 64-bits ⚬ Settings: improvedtube.json

⚬ OS: Windows 10 ⚬ Device:

Paahtomarakatti commented 7 months ago

EDIT: Turning the addon off, refreshing the site, turning it on again, navigating to the Appearance->Player->toggling forced theater mode on and off again, and refreshing the site, seems to fix it.

ImprovedTube commented 7 months ago

hi @Paahtomarakatti @Krogume so at least 2 people had this?

you could also click appeareance: sidebar: to the side! (no page margin) (not that it will help)

ImprovedTube commented 7 months ago

youtube might be changing some DOM behaviors (if not CSS names),
affecting how often this code is triggered by our mutation observer:

https://github.com/code-charity/youtube/blob/7f9e9bb79b6040578366dbd97f5b9a8fcf12e664/js%26css/web-accessible/functions.js#L213-L239

(looks unfinished:) https://github.com/code-charity/youtube/blob/7f9e9bb79b6040578366dbd97f5b9a8fcf12e664/js%26css/web-accessible/functions.js#L240-L247