search

code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.53k stars 538 forks source link

Louder sound on video with music #2064

Open xeophyte opened 8 months ago

xeophyte commented 8 months ago

Bug Report:

⚬ BUG: Louder sound on video with music. ⚬ HOW: Load my settings and go to YT page with some music. ⚬ ImprovedTube Version: 4.704

More / optionally:

/ ⚬ Context: Sound is louder on videos with music even though "Forced volume" and "Loudness normalization" are disabled. Try default extension settings and then load my settings on the same YT music page and you will hear the difference. / ⚬ Expected /preferred behavior: no sound change ⚬ Browser: Vivaldi | 6.6.3265.3 ⚬ Settings:
improvedtube.json

ImprovedTube commented 7 months ago

thought this is a feature request, even though i am not sure how relevant of a feature request it could be https://github.com/code-charity/youtube/discussions/1881#discussioncomment-8912041

ImprovedTube commented 7 months ago

hi @xeophyte! You set volume at 100 already; volume_normalization:false and speed at 1.25 except music
Please try if you get this bug still with volume normalization enabled (YouTube's default). Just to make sure (our volume normalization code seems outdated, there should not possible a difference in music volume.)

Also, as we mentioned, our speed feature might have a bug, but hopefully works most of all the time?
and also isn't about volume directly. But please check:

does the bug appear only with new tabs or new sessions? (not after navigating related videos within youtube) @xeophyte

( https://github.com/code-charity/youtube/issues/1856#issuecomment-2020190402 )

xeophyte commented 7 months ago

I think there is no bug with Loudness normalization enabled.

The version from the link probably switches the speed faster from 1.25 to 1.0 when listening to music, but I would prefer it to be changed only AFTER music is detected. Sometimes it is not detected at all, so the default setting should be 1.0, and only after detection should it be switched to the set speed.

Taizunz commented 2 months ago

There's definitely some weird behavior going on with music on YouTube and this extension. I also have "Loudness normalization" disabled, but I have "Forced volume" enabled and set to 15. It's as if music audio is boosted by some base amount, but with "Forced volume" enabled it only happens if you manually adjust the volume of the video after it has loaded. If you just refresh the page and leave the volume slider alone, it doesn't boost the audio. Any type of manual volume adjustment by either dragging the slider, hitting up/down arrow keys or using media player buttons makes it happen.

If I disable "Forced volume", the audio immediately gets boosted when the music video begins.

If I enable "Loudness normalization", the issue stops.

It only happens on music. Non-music youtube videos don't experience this behavior in the many tests I've performed on my client.

This is the music video I used to test: https://www.youtube.com/watch?v=0sRsweB2K7c This is the non-music video I used to test: https://www.youtube.com/watch?v=loP_ePjMQKQ