ImprovedTube
commented
8 months ago thank you! @zweidrache
Closed zweidrache closed 7 months ago
ImprovedTube
commented
8 months ago thank you! @zweidrache
zweidrache
commented
8 months ago @ImprovedTube I discovered something new about this. What I think is happening is that the Live Chat is loading onto that space despite the fact I have it marked as Hidden in the settings. If I set Live Chat to Normal and then manually click the X on its panel to close it from the sidebar, then the screen assumes the correct proportions for Theater Mode. Shown here:
I tried setting this to Collapsed, but it just loads an empty box where Chat should be without any way to close it to get the screen back:
zweidrache
commented
8 months ago (Didn't mean to close this prematurely. I thought that was button was talking about closing the Preview, not the whole ticket. New to github commenting sorry. :x )
PoorChameleon
commented
8 months ago Does the following work?:
Either in userstyles (like stylus that's pointed to the correct url)
ytd-watch-flexy[fixed-panels] #panels-full-bleed-container{
display: none;
}or alternatively an uBO rule
! 2024-03-12 https://www.youtube.com
www.youtube.com###panels-full-bleed-container
SirVG
commented
8 months ago Does the following work?: or alternatively an uBO rule
! 2024-03-12 https://www.youtube.com www.youtube.com###panels-full-bleed-container
I tried this personally and it worked. Thank you.
Edit: The playlist/recommended videos does have a gap to the right, but at least the video plays as it should.
zweidrache
commented
8 months ago Does the following work?:
Either in userstyles (like stylus that's pointed to the correct url)
ytd-watch-flexy[fixed-panels] #panels-full-bleed-container{ display: none; }or alternatively an uBO rule
! 2024-03-12 https://www.youtube.com www.youtube.com###panels-full-bleed-container
the UBO rule causes the video to take up correct porportions, but if I happen to open the live chat it overlaps. also the sidebar for video recommendations below the videos now load offset from the right side of the page. neither are a big deal to me, compared to having Theater Mode back, though I can't help but feel there's going to be knock-on effects from this. I just hope that if such a thing happens I remember I put the rule there in the first place and can remove it. Thank you for your suggestions! I'd still like a fix in the extension itself so I'm leaving this as an Open issue.
live chat overlapping using UBO rule in theater mode:
offset recommendations below video in theater mode:
ImprovedTube
commented
8 months ago hi @zweidrache
html[it-livechat='hidden'] ytd-watch-flexy[fixed-panels] #panels-full-bleed-container{ display: none; }
we could also get the CSS selector of youtube's livechat close button and click that before hidding or collapsing.
[ ] while our live-chat collapse is a JS feature and shows a button instead or used to?
[ ] to minimize issues/confusion, we can always consider something like adding a new option called removed and renaming the old one as invisible(legacy), just incase anybody likes that by now
..and so on...
guai
commented
7 months ago I have that same issue in ver 4.642 with chat hidden and forced theater mode. I'd like to have that new 'remove' option
sonal-g123
commented
7 months ago Facing the same issue. Wasn't a problem before. Ver 4.820
Bug Report:
⚬ BUG: When viewing a youtube video that is the playback of a livestream in theater mode, there is a small black horizontal bar across the screen above the top edge of the video frame, and then another larger one on the right side. it looks as if the page's header menu and sidebar would fit there however I currently have the top menu set to auto-hide unless moused over, and theater mode should push the sidebar down below the video here just as it does on a normal upload. Otherwise the video will properly shift to align to the left and bottom edges. ⚬ HOW: Open a youtube video page of an ungoing or archived livestream (VOD) broadcast and then press T or the appropriate button on the video to try to activate Theater Mode. ⚬ If a YouTube change started the bug, please copy the DOM you get (especially if the bug doesn't happen when you log out or on another computer) ⚬ Or did our last update start the bug? I was watching videos fine at least 1 day before posting this, but I don't know if my extension had updated between then and now or this is something else ⚬ ImprovedTube Version: 4.704
1. Thanks for coming & caring! Before submitting, please check if the issue has already been reported ever. With GitHub's issue search (use this link) (else removing "is:issue is:open" from the standard search) ( - If it was posted before, you can answer/react there to give it your voice and move it up in the lists) ( - If the status is "closed" (=fixed) recently, then Web Stores can be updated soon - if it was closed month or years ago, then it might reappeared & must be fixed again.)
2. To give us a chance to solve the bug: Can you ...?:
<html style="font-size: 10px;font-family: Roboto, Arial, sans-serif;" lang="en" darker-dark-theme="" darker-dark-theme-deprecate="" system-icons="" typography="" typography-spacing="" it-pathname="/watch" it-below-player-loop="true" it-below-player-pip="false" it-below-player-screenshot="false" it-channel-default-tab="/videos" it-channel-trailer-autoplay="false" it-custom-player-size-height="900" it-custom-player-size-width="1600" it-forced-theater-mode="false" it-ga="1668368995359" it-header-hide-country-code="false" it-header-hide-right-buttons="false" it-header-improve-logo="false" it-header-position="hover_on_video_page" it-hide-footer="true" it-hide-gradient-bottom="true" it-hide-playlist="false" it-hide-shorts-remixing="false" it-hide-voice-search-button="false" it-limit-page-width="true" it-livechat="hidden" it-mark-watched-videos="true" it-no-page-margin="false" it-player-ads="block_all" it-player-autoplay="false" it-player-hamburger-button="false" it-player-popup-button="false" it-player-quality="hd1080" it-player-remaining-duration="false" it-player-show-cards-on-mouse-hover="true" it-player-size="do_not_change" it-player-subtitles="false" it-player-transparent-background="false" it-related-videos="normal" it-sidebar-left="false" it-subtitles-language="en" it-theme="dark" it-thumbnails-hide="false" it-thumbnails-right="false" it-up-next-autoplay="false" it-watched="[object Object]" it-youtube-home-page="/" data-page-type="video" data-system-color-scheme="dark">More / optionally:
⚬ Screenshots:
this is what the same VOD looks like when I try to toggle on theater mode
here is a normal youtube uploaded video (NOT a livestream) in light mode
and here is the normal youtube upload's theater mode engaged, working as intended (basically fullscreen but within the bounds of the window)
this is what a VOD looks like in light mode as I have it configured for default proportions
Here's the livestream playback on my second, vertical monitor, to show you just how much it fails to stretch the video to proper proportions.
/ ⚬ Context: for the record my desktop resolution is set to 1920x1080 and I use my browser maximized but do not fullscreen videos (I checked just in case, but fullscreen works just fine) / ⚬ Expected /preferred behavior: See the screenshot comparisons of how it should (and used to) work on all videos regardless of if it's a livestream or not. ⚬ Browser: Brave 1.63.165 (Chromium 122.0.6261.64 ⚬ Settings:
{"below_player_loop":true,"below_player_pip":false,"below_player_screenshot":false,"channel_default_tab":"/videos","channel_trailer_autoplay":false,"custom_player_size_height":"900","custom_player_size_width":"1600","forced_theater_mode":false,"ga":1668368995359,"header_hide_country_code":false,"header_hide_right_buttons":false,"header_improve_logo":false,"header_position":"hover_on_video_page","hide_footer":true,"hide_gradient_bottom":true,"hide_playlist":false,"hide_shorts_remixing":false,"hide_voice_search_button":false,"limit_page_width":true,"livechat":"hidden","mark_watched_videos":true,"no_page_margin":false,"player_ads":"block_all","player_autoplay":false,"player_hamburger_button":false,"player_popup_button":false,"player_quality":"hd1080","player_remaining_duration":false,"player_show_cards_on_mouse_hover":true,"player_size":"do_not_change","player_subtitles":false,"player_transparent_background":false,"related_videos":"normal","sidebar_left":false,"subtitles_language":"en","theme":"dark","thumbnails_hide":false,"thumbnails_right":false,"up_next_autoplay":false,⚬ OS: Windows 10