search

code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.5k stars 527 forks source link

Subscription page forgets list view #2105

Closed Shad0wRyu closed 7 months ago

Shad0wRyu commented 7 months ago

Bug Report:

⚬ BUG: Videos on subscription page change arrangement settings after refresh ⚬ HOW: On Opera GX, ImprovedTube version 4.780, going to the subscription page and arranging videos by list. Refresh the page twice and they default back to grid pattern ⚬ If a YouTube change started the bug, please copy the DOM you get (especially if the bug doesn't happen when you log out or on another computer) ⚬ Or did our last update start the bug? Only started after latest ImprovedTube update ⚬ ImprovedTube Version: 4.780

1. Thanks for coming & caring! Before submitting, please check if the issue has already been reported ever. With GitHub's issue search (use this link) (else removing "is:issue is:open" from the standard search) ( - If it was posted before, you can answer/react there to give it your voice and move it up in the lists) ( - If the status is "closed" (=fixed) recently, then Web Stores can be updated soon - if it was closed month or years ago, then it might reappeared & must be fixed again.)

2. To give us a chance to solve the bug: Can you ...?:

More / optionally:

⚬ Screenshots:
/ ⚬ Context: / ⚬ Expected /preferred behavior: ⚬ Browser: Chromium version:121.0.6167.186 ⚬ Settings:

⚬ OS: Windows 11 ⚬ Device:

ImprovedTube commented 7 months ago

hi @Shad0wRyu, thanks! rolling back to the previous version for today. hi @raszpl! Want to revise your recent commits about cookies?

raszpl commented 7 months ago

hi @Shad0wRyu, thanks! rolling back to the previous version for today.

You rolled back to completely broken version, why? it crashes at https://github.com/code-charity/youtube/issues/2058 and doesnt do anything handled by ytElementsHandler beyond that point. Themes are broken, autoplay is broken, "default channel tab" is broken.

hi @raszpl! Want to revise your recent commits about cookies?

edit: I looked at wrong thing, rechecking. I was wrong, YT does indeed save "subscription page arrangement settings". In PREF f6 of all places. PREF = "...&hl=en-US&f6=1" for List PREF = "...&hl=en-US&f6=401" for List with YT Dark theme &f6=80000 YT light &f6=80001 List YT light

Old broken version works because its so broken it cant even override f6 properly when saving themes, it either doesnt touch cookies leaving broken theme (most people never used extension theme support so didnt trigger it), or if you change themes couple of times in a row it corrupts the cookie - user sees list setting changed, sets it again in YT and that overrides PREF fixing cookie but leaves broken theme.

New build fixed themes and properly overrides f6. Sadly f6 wasnt fully documented anywhere, I even asked what it does before committing the patch :(

Shad0wRyu commented 7 months ago

It absolutely does work that way. I did turn off the extension and test it. The subscription page settings remained every time. Are you just looking at the subscription feed on the home page?

-------- Original message -------- From: Rasz_pl @.> Date: 3/18/24 9:49 AM (GMT-05:00) To: code-charity/youtube @.> Cc: Shad0wRyu @.>, Mention @.> Subject: Re: [code-charity/youtube] Subscription page forgets list view (Issue #2105)

hi @Shad0wRyuhttps://github.com/Shad0wRyu, thanks! rolling back to the previous version for today.

You rolled back to completely broken version, why? it crashes at #2058https://github.com/code-charity/youtube/issues/2058 and doesnt do anything handled by ytElementsHandler beyond that point.

hi @raszplhttps://github.com/raszpl! Want to revise your recent commits about cookies?

why? This a completely bogus bug report, Youtube doesnt do what Shad0wRyu thinks it does. Youtube doesnt save "subscription page arrangement settings". Disable extension and check for yourself.

— Reply to this email directly, view it on GitHubhttps://github.com/code-charity/youtube/issues/2105#issuecomment-2003966180, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHBWVY2S6NFFB7UQ7OWY2GDYY3WGHAVCNFSM6AAAAABE2ZISM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBTHE3DMMJYGA. You are receiving this because you were mentioned.Message ID: @.***>

raszpl commented 7 months ago

It absolutely does work that way. I did turn off the extension and test it. The subscription page settings remained every time. Are you just looking at the subscription feed on the home page?

I edited my reply an hour ago after rechecking. Initially I thought you meant channel video feed.

Shad0wRyu commented 7 months ago

Ah, I didn't see the edit. I'm just getting emails.

-------- Original message -------- From: Rasz_pl @.> Date: 3/18/24 11:08 AM (GMT-05:00) To: code-charity/youtube @.> Cc: Shad0wRyu @.>, Mention @.> Subject: Re: [code-charity/youtube] Subscription page forgets list view (Issue #2105)

It absolutely does work that way. I did turn off the extension and test it. The subscription page settings remained every time. Are you just looking at the subscription feed on the home page?

I edited my reply an hour ago after rechecking. Initially I thought you meant channel video feed.

— Reply to this email directly, view it on GitHubhttps://github.com/code-charity/youtube/issues/2105#issuecomment-2004169214, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHBWVY4O2TJMBNKSABO7B23YY37M7AVCNFSM6AAAAABE2ZISM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGE3DSMRRGQ. You are receiving this because you were mentioned.Message ID: @.***>

raszpl commented 7 months ago

Sorry, I wrote my initial reply too quickly without verifying thoroughly.

Shad0wRyu commented 7 months ago

Hey, no worries

-------- Original message -------- From: Rasz_pl @.> Date: 3/18/24 11:52 AM (GMT-05:00) To: code-charity/youtube @.> Cc: Shad0wRyu @.>, Mention @.> Subject: Re: [code-charity/youtube] Subscription page forgets list view (Issue #2105)

Sorry, I wrote my initial reply too quickly without verifying thoroughly.

— Reply to this email directly, view it on GitHubhttps://github.com/code-charity/youtube/issues/2105#issuecomment-2004295811, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHBWVY426OCQQWVZM3QI27DYY4ET5AVCNFSM6AAAAABE2ZISM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGI4TKOBRGE. You are receiving this because you were mentioned.Message ID: @.***>

ImprovedTube commented 7 months ago

Sadly f6 wasnt fully documented anywhere, I even asked what it does before committing the patch :(

👍👍 @raszpl

You rolled back to completely broken version, why?

it can be done in a minute (simple trade-off since old bugs don't cause new confusion like new bugs, so usually it is right to test for short at a time Uninstalls )

it crashes at https://github.com/code-charity/youtube/issues/2058 and doesnt do anything handled by ytElementsHandler

👍 so hideDetailButton() doesn't run i shouldn't have missed this in 2023. The fix is in included in the store version (v4.805)

beyond that point. Themes are broken, autoplay is broken, "default channel tab" is broken.

really? It should only break those ytElementsHandler() function calls leading to call hideDetailButton()

raszpl commented 7 months ago

it can be done in a minute (simple trade-off since old bugs don't cause new confusion like new bugs, so usually it is right to test for short at a time

I understant reverting on main extension. I think I asked about it already long time ago - isnt that what https://chromewebstore.google.com/detail/improve-youtube-%F0%9F%8E%A7-for-yo/lodjfjlkodalimdjgncejhkadjhacgki is for? I even asked why didnt you rename it to [Testing] or [Staging].

beyond that point. Themes are broken, autoplay is broken, "default channel tab" is broken.

really? It should only break those ytElementsHandler() function calls leading to call hideDetailButton()

you are probably right, but "Themes are broken, autoplay is broken, "default channel tab" is broken." are still true for version currently in store

ImprovedTube commented 7 months ago

autoplay

did you fix autoplay?

testing

yes can, run slow tests with the testing version.
(So it might takes 2 weeks to get the same amount of bug reports, as a day in the main version) (so it can be worth the trade-off to get a faster bug report for 300 extra uninstalls. More so while you are active 🎉 )

*Or any percentage of users, but in the past this webstore feature didnt work for us)

(Also updating both at once, the main version usually takes some more hours/days to be reviewed, while the test might passes immediately, so if a bug was noticed in testing already, we might canceled the review for the main version (while rolling back will take another review cycle at ChromeWebStore, unlike Firefox)

raszpl commented 7 months ago

autoplay

did you fix autoplay?

its not "broken" broken, you added code breaking it deliberately with https://github.com/code-charity/youtube/commit/dc00a7e92701c83e2722c2346275a3380cc61d11 "fixes & tidy" https://github.com/code-charity/youtube/issues/2042#issuecomment-1975897575