code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.53k stars 540 forks source link

Opening in new tab doesn't apply settings (playback speed, fullscreen, autoplay) - clearing cookies fixes it for a time #2136

Open Jerrk opened 7 months ago

Jerrk commented 7 months ago

1. Bug Report:

BUG:
When opening a video in a new tab, it appears none of the settings in the extension will apply. But if i then from that video navigate to a different video, the settings will apply.

It will also apply the settings if i press i to open the miniplayer, and then press i again to go back to the full video player. So it appears that the settings will apply when the player is "reloaded"?

⚬ Browser:
Chromium Version 123.0.6312.90

HOW:
Clear cookies, login, play a certain amount of videos (not sure about this step here because it sometimes happens after a couple of days and sometimes it happens the same day), open a video in a new tab, see the issue, clear cookies, login, the issue is gone.

⚬ Does the bug not happen when you log out of YouTube? It appears that logging out does indeed fix this issue, so it appears to be tied to your account? maybe after x amount of videos watched on an account they load the player differently? ctrl+u gave me this: ctrl+u.txt

It may be related to #1851 #2012 and #1856

raszpl commented 7 months ago

I think its a deeper failure of the extension to initialize I just caught something similar when opening video from a link on another site, extension failed to load properly: bad page refresh and everything was fine again: good

sadly those pictures are useless for debugging, but it was teh only difference I could spot, console was clear of errors :(. I added some console.logs to both extension/web-accessible core/init.js so next time this happens I can at least see where the problem was

Jerrk commented 7 months ago

For me a page refresh does not fix the issue and load the extension in this situation.

raszpl commented 7 months ago

This extension dosnt use cookies for at all, so clearing cookies will have no influence over the way it works. What does change is you are being logged out of YT without cookies. Its possible YT is forcing you into some new experiment. I dont even know how to check for that, @ImprovedTube will know more.

Jerrk commented 7 months ago

yes that is my guess as well

CodeClimberNT commented 6 months ago

I'm adding myself to this issue. I find also the hamburger menu in the player not showing when opening a video in a new tab and also an annoying bug with the short when opened (the audio is played but an overlay to show that an user input is required to start the video resulting in a strange experience), as before, in a new tab. All the problem are fixed when (for a video) open a new one in the same tab and come back using the browser navigation function, and for the shorts video scroll to load the next and go back up to load again the previous one.

Jerrk commented 5 months ago

Because google seems to handles different areas around the world a bit differently for whatever reasons, all issues aren't reproducible in all locales.

What i'm guessing is happening to me is that after X amount of videos watched on MY account, youtube becomes more aggressive with its advertisements and tries to load one before the player is available.

Thus ImprovedTube's player modifications are unable to be applied on load.

The delay at the start of the video seems to be random as well, so a simple delay would not be ideal.

Is there any more info you'd like me to grab for you?

raszpl commented 5 months ago

I dont even test without uBlock Origin :(

Jerrk commented 5 months ago

Even with all extensions disabled (including improvedTube) i still get the delay on load.

On top of that disabling VPN, dns adblocker, and socks proxy, i STILL get the delay.

Enabling improvedTube and explicitly turning ads ON, still get the delay.

After deleting the youtube.com and google.com site cookies + data the delay is gone and auto fullscreen + playback speed works.

🤷

raszpl commented 5 months ago

try with uBlock Origin installed, it blocks some of YT nonsense

Jerrk commented 5 months ago

it is installed, hasn't helped.

Jerrk commented 4 months ago

i've had the free premium membership since the 21st of june and i've not had this issue since, so it definitely seems to be an adblocking thing.

ImprovedTube commented 4 months ago

hi and thanks! @Jerrk