search

code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.33k stars 504 forks source link

Auto speed stopped working for me #2175

Open Walkerbo opened 3 months ago

Walkerbo commented 3 months ago

1. Bug Report:

I have set all vvids to run at 1.75% yet each video only plays at normal speed.

Using Chome web-browser Also have installed:

kashvi0 commented 3 months ago

have you checked the "Remember playback speed" option? remember to scroll down and save changes after you change any settings. please let me know if the issue still persists.

ImprovedTube commented 3 months ago

@Walkerbo since when? did you notice the music-exclusion? It generally works and video playback is expected to change hardly (unlike youtube's layout)

hi @kashvi0, whats going on?

Walkerbo commented 3 months ago

I cannot see a "Remember Playback Speed" option, and there does not seem to be a save button.

I have attached a gif that shows you what I see. YoutubeSpeed

ImprovedTube commented 3 months ago

sorry, i know, @kashvi0's comment is fantasy or AI.

ImprovedTube commented 3 months ago

nice to see your video counter near 12000 @Walkerbo did you make your whole .gif & comment within 1 minute?

kashvi0 commented 3 months ago

@Walkerbo sorry, i really wanted to help but got the features confused. i'm really sorry.

@ImprovedTube i assure you, my comment is not AI (idk what you mean by fantasy). sorry again.

ImprovedTube commented 3 months ago

@kashvi0 Fantasy and or AI can be used for something good.
We didnt have any "Remember ____"-buttons, or "Save changes"-buttons. You might only come up with this if you didn't use this app before. Every setting is remembered with one click.

Walkerbo commented 3 months ago

There seems to be some posts here that are AI so I not sure what some of them mean but I did not write the post that has fantasy in it. I wrote the original bug post and the post that has the gif, none of the others were by me. I can confirm that I have used your extension for a very long time without issue.

ImprovedTube commented 3 months ago

hi! @Walkerbo yes, please check the browser console on youtube for clues about the bug. The following step/s in our bug-report template, like logging out might also help (and checking the experiments-list if so).

CodeClimberNT commented 3 months ago

I found myself experiencing the same bug, from the list of extension provided I have in common only return of dislike button, although disabling it doesn't change anything. Is there a way to see in the console only the error thrown by a single extension? Although the video does not start with the requested speed, the shortcut I can change it without any problem and changing the default speed when a video is playing does indeed change it in real time.

ImprovedTube commented 2 months ago

other browser users or incognito window

ImprovedTube commented 2 months ago

hi! @CodeClimberNT @Walkerbo does this actually happen always? #2028 thanks!

Walkerbo commented 2 months ago

@ImprovedTube For me the speed issue did not happen always, but now it seems to be working correctly for me.

ImprovedTube commented 2 months ago

thanks! @Walkerbo works since a few days? at what frequency didn't it work before? and what browser (or anything you might have in common @CodeClimberNT )

Walkerbo commented 2 months ago

@ImprovedTube, has been working since Monday so almost 3 days. How frequently; there were days when it didn't work at all, no matter what I tried; and other days when it worked only on some of the videos I opened. I use Chrome and have attached a list of all of the extensions I use.

Cdawapture
Walkerbo commented 2 months ago

It has stopped working again. Some speed up and others do not. Those that do not I have to manually speed up.

CodeClimberNT commented 1 month ago

hi! @CodeClimberNT @Walkerbo does this actually happen always? #2028 thanks!

Sorry for the late response, it always happens, but the behavior is kind of strange There are two possible cases:

  1. the extension did not initialize properly, and the experience is pretty similar to the usual YouTube behavior → usually a refresh of the page fix the issue and set the correct speed (still kind of annoying to refresh every video I watch)
  2. the extension actually work but the autospeed does not set automatically but the shortcut works and I can set it up quickly that way.

In reference to the other issue where I was mentioned (#2137) this issue was fixed, but still have troubles with the speed, although now it's much more manageable

colinstu12 commented 3 weeks ago

I'm experiencing this issue too. Even a page refresh does not fix this. The only time it seems to work is if the tab has been discarded in the background and then the page reloads when going back to it. But as far as opening links to videos normally and refreshing normally, it does not apply the speedup.

raszpl commented 3 weeks ago

this is why it doesnt work:

https://github.com/code-charity/youtube/blob/26eb6078f2cd0193ececacc40be45cb69138c2ac/js%26css/web-accessible/www.youtube.com/player.js#L87-L209

its a jungle, last time I was here it was 1/6 the size and still required fixing https://github.com/code-charity/youtube/pull/1729

ImprovedTube commented 1 day ago

hi! @CodeClimberNT @colinstu12 @raszpl @Walkerbo @kashvi0

prior to #2175 https://github.com/code-charity/youtube/commit/67d8db56e09b7f99c25ed45a72512d540e5b4c7a ( in response to https://github.com/code-charity/youtube/issues/1760#issuecomment-1843979778 ) or this: https://github.com/code-charity/youtube/blob/26eb6078f2cd0193ececacc40be45cb69138c2ac/js%26css/web-accessible/www.youtube.com/player.js#L92-L93 ) While #1856 might be prior and independent to the addition that scared you @raszpl : https://github.com/code-charity/youtube/commit/78cebf3137d716e80b4844bf5178d63d53ef640b ( by what @shadow-ryu said )

to be precise again: when clicking related videos and also excluding music, then it might take seconds to undo the speed while we wait for data for infos from invidious or Youtube. And some invidious nodes didn't work so the list is currently reduced to just the top few.