search

code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.31k stars 501 forks source link

Shifting video player on x2 speed shortcut #2229

Open 0x0017 opened 2 months ago

0x0017 commented 2 months ago

Required: Appearance → Comments Sidebar ✔

Bug: When using standard shortcuts for x2 speed, be it “hold space” or “hold LMB on player”, the player window shifts to the upper right corner. The bug is not present when using “Shift + <” and “Shift + >” to change playback speed. Persist on both private and default modes. Resolution: 1920x1080 Browser: Firefox 125.0.2 | Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:125.0) OS: Windows 10

improvedtube.json

https://github.com/code-charity/youtube/assets/100290901/454947b1-e8a6-4116-9894-fe520dfe2ac1

ImprovedTube commented 2 months ago

thanks! @0x0017 (this must be another report with a solution in mind.)
(hi! @D-Rekk (only if you like))

raszpl commented 1 week ago

eeeew this stupid layout happens in here https://github.com/code-charity/youtube/blob/e1c339d6b994d8824779f9cd55ca096d42838ec9/js%26css/web-accessible/www.youtube.com/appearance.js#L236-L239

as soon as I saw setTimeouts I knew it is broken :)