code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.3k stars 501 forks source link

Conflicts with other addons #2255

Open bottleblue opened 1 month ago

bottleblue commented 1 month ago

Firefox 125.0.3 Improved YT 4.805

This is a good addon but it causes issues with other addons:

ImprovedTube commented 1 month ago

hi & thanks @bottleblue (i put these three in opposite order)

The 1rd one comes under MIT license so we should make a merged feature? @nralbrecht https://github.com/nralbrecht/youtube-hide-controls/issues

2nd: Unfortunately even with 92000 daily users, i can't assume much intersection in user base. - Yet maybe it applies more often and we can avoid catching clicks first by some click event listener?

( 3rd: Yet I only know YouTube scrolls up when closing the video description. )

bottleblue commented 1 month ago
  1. That would be nice but if it conflicts with the other addons I would probably still have to stop using it.

  2. Maybe it could be an easy fix.

  3. I set video description to Normal and Hidden but it still doesn't respond to the rocker gestures.

ImprovedTube commented 1 month ago

With nothing set, ImprovedTube shouldn't conflict with 1. 🤔

bottleblue commented 1 month ago

What do you mean nothing set? You mean when Hide Player Controls bar is set to off?

ImprovedTube commented 1 month ago

hi! @bottleblue yes!

bottleblue commented 1 month ago

I still have problems with Hide YT Fullscreen even with the latest update. I should have clarified though in my original post, when you pause/play with the spacebar it will cause the control bar to reappear. Although it also happens if I pause/play with mouse even if the cursor is inside the trigger distance.

I see you fixed the problems with Gesturefy and ContextSearch. Thank you for that!

ImprovedTube commented 1 month ago

hi! @bottleblue, good to know! not sure what fixed it. Besides we canceled body { Overflow-x:hidden } in the firefox version, since there is a bug in firefox causing this to break middle click scrolling. https://github.com/code-charity/youtube/issues/1649#issuecomment-1502296560

to find out if that's related to one or both issues, can you install from the repo, after removing this line? : https://github.com/code-charity/youtube/blob/74b76854384e757ca139286eee9a1561cce8cd01/js%26css/extension/www.youtube.com/styles.css#L6

bottleblue commented 1 month ago

to find out if that's related to one or both issues, can you install from the repo, after removing this line? :

sry I don't understand what to do