search

code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰100+clever features📌set&forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.29k stars 500 forks source link

Update init.js ImprovedTube.livechat collapsed called too early #2298

Closed raszpl closed 1 month ago

raszpl commented 1 month ago

https://github.com/code-charity/youtube/blob/d8065714b67e4bbb891b11eedd72ef68f0afed38/js%26css/web-accessible/www.youtube.com/appearance.js#L316-L322

called in init https://github.com/code-charity/youtube/blob/d8065714b67e4bbb891b11eedd72ef68f0afed38/js%26css/web-accessible/init.js#L106

appearance.js:320 Uncaught TypeError: Cannot read properties of undefined (reading 'click') at ImprovedTube.livechat (appearance.js:320:51) at ImprovedTube.init (init.js:106:7) at HTMLDocument. (core.js:176:17)

git blame shows it has been like this for at lest two years

ImprovedTube.elements.livechat stays initialized as empty object https://github.com/code-charity/youtube/blob/d8065714b67e4bbb891b11eedd72ef68f0afed38/js%26css/web-accessible/core.js#L25

until https://github.com/code-charity/youtube/blob/d8065714b67e4bbb891b11eedd72ef68f0afed38/js%26css/web-accessible/functions.js#L145-L148

ImprovedTube commented 1 month ago

also, [aria-label="Close"] exists several times in different panels