search

code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰100+clever features📌set&forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.29k stars 499 forks source link

It stops my videos when im in the home page #2305

Open beCe3-veqnor opened 1 month ago

beCe3-veqnor commented 1 month ago

1. Bug Report:

raszpl commented 1 month ago

hovering over video triggers creation of video preview, extension somehow assumes its a real video playing.

ImprovedTube commented 1 month ago

hi! @beCe3-veqnor sounds like you are you using the feature player:auto-pause while i'm not in the tab or pause while i play a 2nd video

ImprovedTube commented 1 month ago

2225

ImprovedTube commented 1 month ago

real video

can actually navigate the whole video in those previews, if we mean the same thing

raszpl commented 1 week ago

both autoplayDisable() and https://github.com/code-charity/youtube/blob/85bf12458d10dbc15ab4d8da057da01b5d8e152d/js%26css/extension/www.youtube.com/general/general.js#L144-L152 dont even try to detect video previews

place where fix should go is autoplayDisable() https://github.com/code-charity/youtube/blob/85bf12458d10dbc15ab4d8da057da01b5d8e152d/js%26css/web-accessible/www.youtube.com/player.js#L31-L35 only send it-play message when real video is playing, ignoring video previews. even earlier in https://github.com/code-charity/youtube/blob/2bbf665a08704b5aeba467c4e55d9a940a9c87b3/js%26css/web-accessible/functions.js#L325-L330 detect if video preview and skip straight to https://github.com/code-charity/youtube/blob/2bbf665a08704b5aeba467c4e55d9a940a9c87b3/js%26css/web-accessible/functions.js#L344