code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰100+clever features📌set&forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.29k stars 498 forks source link

Screenshot button doesn't work on firefox #2341

Closed junvm closed 1 week ago

junvm commented 2 weeks ago

Bug Report:

please check, if the issue has already been reported ever. (If so, that might inspires you to add different/better words to that report.) [GitHub's issue search](https://github.com/ImprovedTube/ImprovedTube/issues?q=) _(use the link or remove "is:issue is:open" from the search)_
raszpl commented 2 weeks ago

works fine in firefox

https://developer.mozilla.org/en-US/docs/Web/API/ClipboardItem

"Uncaught ReferenceError: ClipboardItem is not defined" means your have some tracking blockers disabling standard browser features installed

junvm commented 2 weeks ago

works fine in firefox

https://developer.mozilla.org/en-US/docs/Web/API/ClipboardItem

"Uncaught ReferenceError: ClipboardItem is not defined" means your have some tracking blockers disabling standard browser features installed

I disabled ublock which is the only other sort of tracking blocker I have and it still gives me that error with no screenshot

raszpl commented 2 weeks ago

disable all extensions but improvetube and try again does this https://jsfiddle.net/rasz_pl/8tkdxL0q/ show same message in lower right corner?

junvm commented 2 weeks ago

Disabling every extension but improvetube still gives me the same error. Yes, it says "40:1 ReferenceError: ClipboardItem is not defined"

raszpl commented 2 weeks ago

What browser are you using exactly? Full version please :) https://caniuse.com/clipboard suggests you might be using 3 year old browser.

junvm commented 2 weeks ago

Firefox 126.0.1 (64-bit)

raszpl commented 2 weeks ago

duh I read the date wrong, ClipboardItem will be supported in FF starting, and Im not joking, tomorrow on 2024-06-11 I cant find a way of pasting image into clipboard under FF. Perhaps ImprovedTube.storage.player_screenshot_save_as == 'clipboard' should be disabled if FF is detected.

@junvm enter save as in extension search bar (top of popup), it will find "save as" option set to clipboard, switch it to File instead.