code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.55k stars 545 forks source link

Screenshot to Clipboard not working. #2379

Open Venombeyond opened 5 months ago

Venombeyond commented 5 months ago

I have the extension set, to copy screenshots from youtube to Clipboard. However now whenever I take them, it tries to save it. I tried switching it back and forth, and no matter what i choose, it tries to save the file, rather than copying it to the clipboard. The clipboard doesn't even get an extra copy, it's whatever i copied last.

raszpl commented 5 months ago

clipboard screenshot dont work in FF (api not implemented up to 125) and probably Safari (permissions not satisfied by problematic click handler). But from your report it sounds like clipboard worked before, and the FF patch is not even merged yet https://github.com/code-charity/youtube/pull/2373

I can definitely reproduce sometimes empty clipboard after calling https://github.com/code-charity/youtube/blob/011ea52b9f30ea0c9562967b5bb4697851397448/js%26css/web-accessible/www.youtube.com/player.js#L567-L571 in Chrome, but its very rare and I cant find rhyme or reason. I switch to https://chromewebstore.google.com/detail/improve-youtube-test/lodjfjlkodalimdjgncejhkadjhacgki and it starts working, I switch back to https://chromewebstore.google.com/detail/improve-youtube-%F0%9F%8E%A7-for-yo/bnomihfieiccainjcjblhegjgglakjdd and it works again?!?!

hmm so maaaybe clicking clipboard item too fast before browser finished rendering YT page can cause this, but Im not even sure of that. Can you please fill whole bug template?

no matter what i choose, it tries to save the file

this suggest the problem is with your extension settings