code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.31k stars 500 forks source link

Suggestion Center video player button icons #2410

Open CatsArmy opened 2 weeks ago

CatsArmy commented 2 weeks ago

Hear me out ok.

when you have a the Share, Download, Super Thanks and the Clip ( and the other ones idk) buttons set to: Icon only you should probably center the icon(svg) so it looks nicer let me show you what i tried:

Currently it looks like this with the said settings: image

But if you do as i suggest it will look like this: image

Note: For some reason when i use the dev tools in the browser it and i resize the html code viewer it just removes some of the buttons don't think this is because of this extension just saying it because the pictures look a bit different.

This can be done by adding style="margin-left:auto; margin-right:auto; display:block;" to the style to the html adding the svg icon

<div class="yt-spec-button-shape-next_icon" style="margin-left:auto; margin-right:auto; display:block;">

Here are some examples of how i did it:

Share Button:

changed this: ```html ``` to this: ```html ```

Download Button:

changed this: ```html ``` to this: ```html ```

Super Thanks Button:

changed this: ```html ``` to this: ```html ```
and so on.

heres a picutre of all the buttons i think i dont know anymore:

image

mnyamunda-scottlogic commented 2 weeks ago

Hi, I would like to be assigned to this issue. Are there any prerequisites?

CatsArmy commented 2 weeks ago

No idea but should be pretty easy as it happens when it removes the text from the icons I'll take a look maybe

Should be a simple one depending on how this extensions works and how YouTube works

I'm not too familiar with it

CatsArmy commented 2 weeks ago

i think it should be somewhere near this part of the code

ImprovedTube commented 1 week ago

https://github.com/code-charity/youtube/blob/26eb6078f2cd0193ececacc40be45cb69138c2ac/js%26css/extension/www.youtube.com/appearance/details/details.css#L15

mnyamunda-scottlogic commented 1 week ago

Thanks folks, will work on this :)

mnyamunda-scottlogic commented 1 week ago

Hey folks I have located the 5 buttons that need to be centred.

Are there some instructions to get a development version of the extension running on my YouTube so I can visually confirm that my code is working? readmes etc

Thanks! :)