search

code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.3k stars 501 forks source link

"Add to Blocklist" button no longer working in Nightly (129.0a1 (2024-06-28) (64-bit)) #2422

Open Eyevou opened 6 days ago

Eyevou commented 6 days ago

I just attempted to block a channel and the button did not function at all.

ImprovedTube commented 4 days ago

hi! @Eyevou

sad, can you tell more? v4.1007? i think @raszpl worked hard on this recently.

Eyevou commented 4 days ago

can you tell more? v4.1007? Yep, 4.1007.

https://www.youtube.com/watch?v=sWNqknrPhl4

This is what happens when attempting to blocklist a channel.

Blocklisting a specific video works fine. It's just the channel block that doesn't appear to function.

raszpl commented 4 days ago

browser? does it say "blocklist click: no channel ID or metadata" in console? Edit: oh the pain, YT is serving three different versions of HTML. Back to 'YTD-SUBSCRIBE-BUTTON-RENDERER', 'YT-SUBSCRIBE-BUTTON-VIEW-MODEL', 'ytd-button-renderer.ytd-c4-tabbed-header-renderer' -one is FF exclusive, in FF button doesnt how at all :| -on one of chrome versions metadata is missing fixed https://github.com/code-charity/youtube/pull/2428

Eyevou commented 4 days ago

browser?

Firefox Nightly.

does it say "blocklist click: no channel ID or metadata" in console?

Yes:

blocklist click: no channel ID or metadata blocklist.js:127:12 onclick moz-extension://26289df2-3403-4e3e-a948-75d66d48b4f8/js&css/web-accessible/www.youtube.com/blocklist.js:127

raszpl commented 4 days ago

Firefox Nightly.

hah, so you get chrome html version in FF, or maybe its not chrome but not logged in one, YT is so weird :|

does it say "blocklist click: no channel ID or metadata" in console?

Yes:

should be fixed after this patch

Eyevou commented 4 days ago

should be fixed after this patch

When the changes get posted to the repo I'll be sure to test it and see. Thanks!