code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}

http://improvedtube.com

Other

3.42k stars 513 forks source link

player controls fixed /sticky #2448

Open Corruptinglyneedful opened 2 months ago

Corruptinglyneedful commented 2 months ago

Sticky player controls, as an example can always up the volume without having to click on the player first.

raszpl commented 2 months ago

you mean player running in another window or tab?

Corruptinglyneedful commented 2 months ago

Nope, we already have a pop out player or a floating mini player.

I'm talking about not having to click on the video in order to change the volume, pause, etc.

On Fri, Jul 5, 2024 at 11:14 PM Rasz_pl @.***> wrote:

you mean player running in another window or tab?

— Reply to this email directly, view it on GitHub https://github.com/code-charity/youtube/issues/2448#issuecomment-2211625170, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMIFZSONMVK44F46MEBECLZK5VKFAVCNFSM6AAAAABKMPOOU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRGYZDKMJXGA . You are receiving this because you authored the thread.Message ID: @.***>

raszpl commented 2 months ago

Now Im even more confused. You want dedicated sticky Volume/Play/Pause buttons because you dont want to click on player? How are you going to use those buttons without clicking on them? :o Btw we do have shortcuts for almost everything.

Corruptinglyneedful commented 2 months ago

I don't know how enchancer for youtube did it, they just had the feature. It was quite useful.

On Sun, Jul 7, 2024 at 12:45 AM Rasz_pl @.***> wrote:

Now Im even more confused. You want dedicated sticky Volume/Play/Pause buttons because you dont want to click on player? How are you going to use those buttons without clicking on them? :o Btw we do have shortcuts for almost everything.

— Reply to this email directly, view it on GitHub https://github.com/code-charity/youtube/issues/2448#issuecomment-2212331871, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMIFZQHE5KRMKUI6UVKC7LZLDIX5AVCNFSM6AAAAABKMPOOU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGMZTCOBXGE . You are receiving this because you authored the thread.Message ID: @.***>

ImprovedTube commented 2 months ago

you mean player running in another window or tab?

still got to repair (migrate) mixer 😳...

Btw we do have shortcuts for almost everything.

and/or having shortcuts working everwhere outside the tab with the HTMLMediaElement. "💡"

Now Im even more confused.

" and this was, how "Hide player controls bar"[when paused|always] was re-named "Player Buttons":[hide when paused|hide always|show always] " @raszpl

ImprovedTube commented 2 months ago

hi! @Corruptinglyneedful

[ ] 1.) Player buttons: below the player or at the bottom of the window(with CSS position: fixed).
(while also/optionally hiding youtube's original controls bar?)

[ ] 2.) Every time you drag left & right on youtube: That must be the timebar (likely). ( Alternatively: Volume. Or volume could be for dragging up&down again like Youtube used to be & Windows. So you could have both. ).
- Imagine this combined with our new feature: general: Dim Youtube's Pages, except what I mouse-over! (please try it). Any dragging wouldn't count as hovering)
- (technically this can be implemented with dispatchEvent() or moving the marker below the cursor for the time of the drag)
- 3.) Context menus:
- [ ] Add pause & mute everywhere to the browser's right-click menu every where on every website as long as an any sound is playing. (this might exists as an extension already?)
- [ ] Make youtube's player's context menu trigger everywhere on the site and add more items, including Volume.
  - [ ] and/or make it trigger on clicks on empty space

ImprovedTube commented 2 months ago

1878

Corruptinglyneedful commented 2 months ago

So it did it to me earlier, after I clicked the time/seek bar to jump to a placement in the video and then went to adjust the volume with the up/down arrows, it instead adjusted the seek bar and jumped me ahead in the video I was watching rather than adjust the volume.

In order to get it to respond to the arrow key for volume I had to click on the video, which pauses it, then click it again and then adjust the volume. The extension I brought up, Enhancer for Youtube; it didn't work like that. It was just always active SOMEHOW but I'm not sure how. As long as I was on the page, I could adjust the volume up and down with the arrow keys. I don't know how they did that but it was really useful.

Maybe this adds context, maybe it doesn't.

ImprovedTube commented 2 months ago

hi! @Corruptinglyneedful you can try to overwrite youtube's defaults at our shortcuts:volume. Even if you set the same key you will see a difference. (you can also use both extensions at once)

Corruptinglyneedful commented 2 months ago

Funny thing, I just checked there. It is already set to up and down arrow by default but I followed your recommendation and went in and set the keys just in case.

Nah, I'm looking to replace Enhancer for Youtube entirely because they do not update fast enough or reliably enough to keep up with stupid Google and a lot of things keep breaking. I also don't want to put up with potential conflict between the two trying to override one another's settings. If Google/Youtube would learn to leave well enough alone it wouldn't be a such problem.

I came to your extension because of how feature rich it is and I notice you are very active in development, which I appreciate. I get WAY more things to play with on this extension compared to others I've tried. It has much more just offered, period and I like that. I especially like the appearance stuff being able to just hide comments, sidebars, buttons, chat, etc instead of outright disabling them is very nice.

Do you have a donation link somewhere?

Corruptinglyneedful commented 2 months ago

Alright so setting the shortcut is actually doing what I want. So thanks for that that is basically what I was looking for. No matter what I'm clicking on the page or where I am, I can adjust the volume even with the mini player active.

ImprovedTube commented 2 months ago

Funny thing, I just checked there. It is already set to up and down arrow by default but I followed your recommendation and went in and set the keys just in case.

hi! @Corruptinglyneedful they aren't set by default, but 🤣 we just used the space to inform about youtube's defaults ( compare #517 + #2442 (3.) and "Allow 60fps" )

active in development

...and we might add another 50 or so tweaks any time if you can give them name? #2251

have a donation link somewhere

What about joining us? 😅 Received very few $ in bitcoin before. Yet we should register a non-profit, think sooner than later and keep making the make the best out of this? And or use CommunityBridge liberapay (Apple Appstore Patreon Tidelift)
Even something like $70/month -10% fee on open-collective can make a happy part time job in a poor place... There a reasons to be enthusiastic everywhere

Corruptinglyneedful commented 2 months ago

Ah, that would explain why I was confused then and couldn't get it to work and Youtube's defaults weren't working how I wanted. Anyways, I basically consider this solved at this point and thank you for your time and help.

I wouldn't be able to contribute to your project in an meaningful way but I appreciate the offer. I don't know how to code or read script or really any of that kind of stuff. I have however, name dropped this project/extension around to my friends so now they are aware of it.

I can give that 1000 tweak list a gander, see if I can come up with anything clever, sure.

I'd was just looking to like throw 10 bucks your way or w/e. I was able to track down crypto donations links but not something like paypal and I don't really understand crypto.