🐞Playback speed isn't always being set properly in new tabs.

Eyevou commented 3 weeks ago

Concise Description

I typically watch videos at 2x speed (force speed, no music override) and have recently been having problems with the videos starting to play at normal speed when switching to a new tab with the video I want to watch. It doesn't seem to be happening every time tho.

The best way I've found to reproduce this bug is to open a video in a separate tab, switch to another tab, close the browser, load the current tab, switch to the old tab.

I wish there was a way to more reliably reproduce this bug but it seems to be spastic at best.

Browser/s

Firefox

Other Browser:

No response

'Steps to reproduce' - Which of our features is required for the bug to happen?

open a video in a separate tab, switch to another tab, close the browser, load the current tab, switch to the old tab

Since when?

For the past week or so, I believe

Does the bug still happen when you log out of YouTube?

None

..No? Then please paste your yt.config_.EXPERIMENT_FLAGS. Twice (With the error & Without)

No response

Are any errors or related log-messages shown in the Browser-Console? (F12)

No response

Tested as the only active extension? (incognito mode or another browser users):

None

Expected preferred behavior:

Always playing at 2x speed

ImprovedTube Version

4.1096

Your Settings (From the Extension's `⋮`-Hamburger menu > Settings > Backup & reset > Export settings)

improvedtube.json

Your YouTube-Document

No response

OS / Device:

Windows 11 23H2 (22631.4169)

2mustange commented 3 weeks ago

I have also encountered this, where playback speed settings don't overwrite whats on a new tab.

ImprovedTube commented 2 weeks ago

Welcome back! @Eyevou Thanks @2mustange Only new tabs and only Firefox? Whats the prevalence of the bug for tabs opened in the foreground; in the background; restored tabs?

2mustange commented 2 weeks ago

Only new tabs and only Firefox?

Yes,, on Firefox

Whats the prevalence of the bug for tabs opened in the foreground; in the background; restored tabs?

I have noticed this mostly in embedded videos. For example i open up a reddit thread that is linking to a video. When expanding the player the embedded video stays at normal speed

Eyevou commented 2 weeks ago

Welcome back! @Eyevou Thanks @2mustange Only new tabs and only Firefox? Whats the prevalence of the bug for tabs opened in the foreground; in the background; restored tabs?

It's mostly on videos that were loaded but in the background but loaded again after a full close/restore of the browser session then focused. As for @2mustange 's "embedded videos" comment I never really expect the addon to effect those videos so I'm not sure, since they've never set speed for me.

I only use firefox so I wouldn't know if it also happens with chromium-based browsers, sorry.

Eyevou commented 2 weeks ago

Here is a video of the bug I'm encountering, notice the playback speed after relaunching the browser on the second and third tab.

https://www.youtube.com/watch?v=jVfiXv3re_g

ImprovedTube commented 5 days ago

Thanks @Eyevou @2mustange and sorry for the delay

Can you confirm the same happens for Force volume but not for Player quality (such as 144p) Else please open the browser console (F12) for a tab where it didn't work. (You might find some log messages by us (white) or some errors (red), or else we can add some more for testing. Good to know if it is only Firefox.)

It is supposed to also work for embedded videos @Eyevou.
I was able to make it not work for embedded videos in chrome through a full reload CTRL+SHIFT+R

code-charity / youtube