code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.54k stars 542 forks source link

Sidebar auto sizing CSS breaks page zoom #2648

Closed XP1 closed 1 week ago

XP1 commented 2 weeks ago

I watch YouTube on 250% zoom.

Bug Report:

"/js&css/extension/www.youtube.com/appearance/sidebar/sidebar.css": https://github.com/code-charity/youtube/blob/master/js%26css/extension/www.youtube.com/appearance/sidebar/sidebar.css#L13

/*--------------------------------------------------------------
# SIDEBAR AUTO SIZING
--------------------------------------------------------------*/
ytd-watch-flexy[flexy] #secondary.ytd-watch-flexy {
    width: auto !important;
    min-width: unset !important;
}

ytd-live-chat-frame,
div#secondary div#related,
div#secondary div#panels,
div#secondary div#donation-shelf,
div#secondary #playlist {
    width: var(--ytd-watch-flexy-sidebar-width);
    min-width: var(--ytd-watch-flexy-sidebar-min-width);
}

For now, I'm injecting my own CSS to disable it:

/* Disable ImprovedTube sidebar auto sizing. */
ytd-watch-flexy[flexy] #secondary.ytd-watch-flexy {
    width: var(--ytd-watch-flexy-sidebar-width) !important;
    min-width: var(--ytd-watch-flexy-sidebar-min-width) !important;
}

/* Disable ImprovedTube sidebar auto sizing. */
ytd-live-chat-frame,
div#secondary div#related,
div#secondary div#panels,
div#secondary div#donation-shelf,
div#secondary #playlist {
    width: auto !important;
    min-width: unset !important;
}
ImprovedTube commented 2 weeks ago

hi! and thanks @XP1, this might be rare, yet we have little code running by default. according to the "blame"-tab the code was originally from https://github.com/code-charity/youtube/commit/4d75643a09af771705e9438b45e6c1105e2891c0 by @dodieboy? (greetings!) and @BogdanskiJ adjusted it later.

dodieboy commented 2 weeks ago

I will take a look on it

ImprovedTube commented 1 week ago

Oh! @dodieboy I better come up with more reasons to tag you