search

code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.54k stars 542 forks source link

Sidebar fix #2663

Closed dodieboy closed 1 week ago

dodieboy commented 2 weeks ago

This should fix #2648 and fix the feature that I added in #1356 cause by Youtube changes

dodieboy commented 2 weeks ago

wait, the issue is not fix. Sry, I doing more testing now

dodieboy commented 2 weeks ago

Now, i can only limit the auto size to when you enable "hide sidebar", then it resize primary div like what i wanted in #1356. To make it look like what i wanted back then, I have to add some js code which will make it that user need to refresh the page

dodieboy commented 2 weeks ago

The cause of issue 2648 is that there is no max-width set for .primary div, but there is no way for me to know the side of the width of the current sidebar size for me to set a calc for .primary div unless I did it in js code

ImprovedTube commented 1 week ago

1356 remembered! yay

ImprovedTube commented 1 week ago

hide sidebar was added later. Previously related videos: hidden did also hide the sidebar

ImprovedTube commented 1 week ago

looking forward!

dodieboy commented 1 week ago

Now the auto width I only set for hide sidebar (as of this pull request you) because if I want to make auto width not limit to hide sidebar, I need to add more check to check is there any element(live chat, donation box) in the sidebar, which need to add js code, which I have no time to develop it

ImprovedTube commented 1 week ago

forgot to merge earlier

ImprovedTube commented 1 week ago

so will it only fix #2648 (a bit rare) or also maybe take away the feature for somebody where it looks good? (many people are used to how it is).

ImprovedTube commented 1 week ago

busy

may your work be meaningful and fun! :) @dodieboy

dodieboy commented 1 week ago

so will it only fix #2648 (a bit rare) or also maybe take away the feature for somebody where it looks good? (many people are used to how it is).

I believe this feature is not working for a few months, and since no one submit a issue, I believe everyone thinks it was a YouTube feature 😄😄