code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.54k stars 542 forks source link

Fix options menu size #2673

Open 4yman-0 opened 1 week ago

4yman-0 commented 1 week ago

Should fix #2569

TODO:

NOTES:

Unfortunately, https://improvedtube.com/wishes is broken and I can't fix it here.

Edit: I think flexbox is grid now

4yman-0 commented 1 week ago

Screenshot from Chromium for now.

ImprovedTube commented 1 week ago

hi! :) @4yman-0

we can start a proper "wishes" here on Github! (CTRL+U)

just to make sure, you might knew the 9 buttons used to be equal sizes 3 x 3. While different sizes now make some sense, the current CSS position adjustments are binding the page to the static 320px width.

4yman-0 commented 1 week ago

chrome-extension___dhggbdhnjdpaeogjfkpebfmjmdlkjmhe_menu_index html_action=export-settings

ImprovedTube commented 1 week ago

hi! sorry i mean, this is what most of all users see currently (the new sizes and order are reasoned) 2024 (All of 2024, thus most important already?) (previously: 3 x 3 (tidy and most years) and 1 x 5 (first 5 years))

(done quickly, this also required to set a max-width for full-tabs chrome-extension://bnomihfieiccainjcjblhegjgglakjdd/menu/index.html, which is fine, since more width doesn't help. and the remaining space can be used better in a full tab)

Will be very worth it to start working on our GUI. Eventually we can also provide full tab menu with player, playlists & history https://github.com/code-charity/youtube/issues/1546 https://github.com/code-charity/History-Manager

broken after a canceled "export settings"

/what did you mean?

ImprovedTube commented 1 week ago

starting at #2569: The scrollbar at chrome://extensions/?options=bnomihfieiccainjcjblhegjgglakjdd can be avoided with a bit less height (520px?), which can be conditional there, because when clicking the browser icon 600px are allowed (and might be more convenient?)

4yman-0 commented 1 week ago

/what did you mean?

Plz don't just respond to issue comments in the request. As for the "breaking":

  1. Go to "Settings"
  2. Choose "Backup"
  3. Choose "Export settings"
  4. Cancel it (should open menu full-tab)
4yman-0 commented 1 week ago

The options menu started from 7d4429374188c1cac12797cf7e695aba25ccf817 (by Lost Author) is very similar to the current one so idk.

4yman-0 commented 6 days ago

@ImprovedTube Any proposals to fix stuff or something (users used to the current layout will be confused).

EDIT 1: Remove stuff

ImprovedTube commented 4 days ago

yes, i mean

Cancel it (should open menu full-tab)

yes, that's currently unnecessary

4yman-0 commented 4 days ago

So in future we might not only want to undo to 3 x 3, but also analyse / keep benefits of the current version? 🤔

So, we want to let users know "Hey, these 2 buttons are important, the next 4 are OK and last 2 are pretty useless".

Probably do some sort of styling that doesn't make it like "Look, a grid!!1!".

4yman-0 commented 4 days ago
We're so back

Here's how it looks like w/ display:flex;width: w%.

chrome-extension___dhggbdhnjdpaeogjfkpebfmjmdlkjmhe_menu_index html

And it does not overflow in normal popup :tada: !