code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.55k stars 543 forks source link

issue #2670 - Feature to remove thumbnail dots #2678

Closed marvinl803 closed 1 week ago

marvinl803 commented 1 week ago

Summary:

This pull request works on issue #2670 removes the dots from the thumbnails.

Please review and let me know if any additional changes are required.

Before: issue-1

After: issue-2

ImprovedTube commented 1 week ago

thank you again!

marvinl803 commented 1 week ago

Hi,

I have made the requested changes. Initially, I attempted to implement the solution the same way I did in my previous PR, but it wasn't working as expected. After investigating, I found the issue and have now implemented the feature in the same way as my last PR. It should work correctly now.

Additionally, I updated the name as requested. Please let me know if it's correct or if you would like me to make further adjustments.

Thank you!

HornyPrivateGamer commented 1 week ago

Summary:

This pull request works on issue #2670 removes the dots from the thumbnails.

Please review and let me know if any additional changes are required.

Before: issue-1

After: issue-2

Hi any way you could remove those margins. That there is a big empy space after removing the three dots. Thansk

ImprovedTube commented 1 week ago

have now implemented the feature in the same way as my last PR. It should work correctly now.

thanks

we can also make it depend on ImprovedTube.storage ... (Our CSS variables are convenient, but conditional JS can be more CPU efficient, since not everybody will use the feature and CSS rules may be evaluated /processed from right to left.)

, while ultimately we can reduce CSS load by moving most CSS to JS, depending if (ImprovedTube.storage...)'s as mentioned (didn't benchmark exactly) ( but that's beyond #2678 )

marvinl803 commented 1 week ago

@HornyPrivateGamer I will look to see if I can come up with a solution for those whitespaces and I will make a new PR with those changes.

HornyPrivateGamer commented 1 week ago

@HornyPrivateGamer I will look to see if I can come up with a solution for those whitespaces and I will make a new PR with those changes.

ok thanks a lot, you the best

ImprovedTube commented 3 days ago

, while ultimately we can reduce CSS load by moving most CSS to JS, depending if (ImprovedTube.storage...)'s as mentioned (didn't benchmark exactly) ( but that's beyond https://github.com/code-charity/youtube/pull/2678 )

...or, in other words, next to our layout features, we can make a collection of all relevant uBlock origin rules (1000's which need no update or are updated by their authors or have a million users all updating manually yet), so then the main work remaining about this will be naming / explaining each optionally and maybe crowd-sourcing.