code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.42k stars 513 forks source link

Firefox ......... EDIT: Firefox Version Uploaded!! 🌞🌞 #440

Closed cpuuntery closed 1 year ago

cpuuntery commented 4 years ago

Try the firefox version! :) thanks 💕 to @victor-savinov!

Please rate it so people notice

https://addons.mozilla.org/en-US/firefox/addon/youtube-addon



(EDIT above by ImprovedTube)



first I want to say that the developers moved me. and I am sorry for everything I said in #420 second, you can install the extension easily on firefox but it is temporarily Untitlbjmbj74ed.png

Capgfhhhhhhhhhhhhhhture.png

voilà

Capnvnvnvnvnture.png

link to the zip file https://www.dropbox.com/s/31ef6160c5mdl1n/ImprovedTube-3.10.zip?dl=0 and there is another error

shortcuts https://www.youtube.com/watch?v=LXb3EKWsInQ:2397
    (Async: EventListener.handleEvent)
    shortcuts https://www.youtube.com/watch?v=LXb3EKWsInQ:2394
    init https://www.youtube.com/watch?v=LXb3EKWsInQ:129
    <anonymous> https://www.youtube.com/watch?v=LXb3EKWsInQ:2834
    injectScript moz-extension://84dcf112-0ea7-410e-867b-11d6c8d4d27d/content-scripts.js:3242
    <anonymous> moz-extension://84dcf112-0ea7-410e-867b-11d6c8d4d27d/content-scripts.js:3390
    apply self-hosted:2159
    applySafeWithoutClone resource://gre/modules/ExtensionCommon.jsm:614
    applySafe resource://gre/modules/ExtensionCommon.jsm:597
    applySafe self-hosted:935
    wrapPromise resource://gre/modules/ExtensionCommon.jsm:827
    (Async: promise callback)
    wrapPromise resource://gre/modules/ExtensionCommon.jsm:813
    callAsyncFunction resource://gre/modules/ExtensionCommon.jsm:1091
    callAsyncFunction resource://gre/modules/ExtensionChild.jsm:701
    callAndLog resource://gre/modules/ExtensionChild.jsm:677
    callAsyncFunction resource://gre/modules/ExtensionChild.jsm:700
    stub resource://gre/modules/Schemas.jsm:2679
    <anonymous> moz-extension://84dcf112-0ea7-410e-867b-11d6c8d4d27d/content-scripts.js:3345
    inject resource://gre/modules/ExtensionContent.jsm:567
    AsyncFunctionNext self-hosted:684

and it will continue throwing this error abut 1000 time and the cpu usige will spike 84dcf112-0ea7-410e-867b-11d6c8d4d27d is the id of ImprovedTube

and the player will not play and it will be like this Captbvnbvnbvnbvure.png but one time I was able to make it play but that was by sheer luck. it happened that i hardcoded the setting for video quality and it worked. so at least the extension can control some aspects of youtube. so the developers don't need to worry about the video quality thingy

ghost commented 4 years ago

@cpuuntery thank you :heart:

If you test ImprovedTube on Firefox and post new issues, then I will make fixes every few days. When it's stable, we will publish it in Firefox Add-ons.

ghost commented 4 years ago

Please post Firefox bugs on this page.

Termuellinator commented 4 years ago

I can confirm that the version from cpuunterys dropbox can be loaded temporarily. But for me (FF 78.0.2 on Linux), no settings that i change are saved in the addon-dialogue once i click out of it. Once i re-open the dialogue i am again asked for the language and all settings are reset. Also, i can't export the settings before clicking out of it (nothing happens). Clicking "Import Settings" opens the Filechooser.

Let me know if there is any kind of log/debug-output i can share to help :)

Very cute uninstall-page btw ^^

ghost commented 4 years ago

@Termuellinator storage bug has been fixed. Try this https://github.com/ImprovedTube/ImprovedTube/archive/master.zip (tested on Firefox 68.10, Linux)

Termuellinator commented 4 years ago

@victor-savinov with that i get the same error ( " File /home/termy/Downloads/ImprovedTube/ImprovedTube-master_1.zip does not contain a valid manifest " ) as with the .zip from the release-page, even if i manually replace the manifest.json with the one from cpuuntery's zip. Edit: just checked, both manifests are identical

ghost commented 4 years ago

@Termuellinator https://github.com/ImprovedTube/ImprovedTube#firefox--waterfox--gnuzilla-and-icecat-and-other

Termuellinator commented 4 years ago

You are right, selecting the manifest.json instead of the .zip works and the settings are kept :+1: I still can't export settings though. Another thing i noticed that the settings "show channel video count" and "how long ago was the video uploaded" under "Appearance -> Details" doesn't work - but from a short test that doesn't work on chrome either, right?

Edit: The Rotate and Popup Buttons under "Player" are offset down and don't disappear if you deactivate the option again (luckily, they disappear on reload of the page :) ) https://i.imgur.com/Cw7XHFM.png Edit2: The option "only one player instance playing" doesn't stop an already playing tab if i open another video in another tab. If i try the same in Chromium, the "older" tab is stopped, so i assume i understand the intention of the option correctly?

ImprovedTube commented 4 years ago

@Termuellinator thanks 👍 summing up:

firefox bugs:

Termuellinator commented 4 years ago

That's at least all i found during my testing/fiddling around, other than that it seems to work really well :+1: The german translation is missing a good bit, i'll clean that up when i find time to do so.

Edit: oh, and firefox bug: can't export the settings Edit2: i just checked - while you can select a file to import settings (i exported them from chromium), the import doesn't change any settings. So for now (due to the temporary addon workaround) you have to set all settings again after every browser restart

cpuuntery commented 4 years ago

@ImprovedTube just to remind you the bug I first mention still exist firefox console is filled to the brim with errors Captugfhgfhgfhgfhre.png and that causes the CPU usage to be high high Untitljhkhjkhkjhked.png

cpuuntery commented 4 years ago

@victor-savinov I managed to track the source of the bug it is in content-scripts.js line 2968 and in shortcuts.js line 314 error

event.path is undefined

Termuellinator commented 4 years ago

looking at the console i can confirm the error-spam, no increased CPU usage though

Termuellinator commented 4 years ago

Testing the master branch from yesterday evening i can report that the Rotate + Popup Buttons are no longer offset down, but still don't disappear when deactivated but rather switch places. The other issues ("only one player instance playing" and import/export of settings) are still present. And i've noticed another bug: The "Mixer" is always saying "No open video tabs", regardless if youtube tabs are open, videos are playing or not.

Jinsgo commented 4 years ago

Hi, I have tested the extension on firefox. Bugs:

Improvedtube 3.78 and Firefox 79.0.

The others options I have tested work perfectly, thank you for the extension is the best ! And sorry for my bad english.

bayazidbh commented 4 years ago

Is there any plan on putting the extension on AMO? Or at the very least releasing an .xpi file. I've been using it and it's fine for the most part, would need to use it more to find any major recurring problems, so an .xpi would be nice for that (I don't know how to package an .xpi from the temp add-on files).

Termuellinator commented 4 years ago

yeah, i agree - biggest issue i have at the moment is going through all the settings every time i start the browser ^^

Jinsgo commented 4 years ago

I have tested the last version of Improvedtube and the shortcuts for screenshot, repeat... are working perfectly.

Refresh youtube page stop the video like this.

For this I have activate the Firefox autoplay option and refresh the page don't stop the video.

cpuuntery commented 4 years ago

@bayazidbh @Termuellinator @Jinsgo Here is a link for an xpi file. download the xpi file

Termuellinator commented 4 years ago

thank you @cpuuntery ! Will report back if i find any new issues (and it seems i already found some new options that i have to add the german translation to ^^) Edit: the "do you enjoy improvedtube" popup links to the chrome-store, that'll have to be changed once it'll hit AMO :)

bayazidbh commented 4 years ago

Thank you @cpuuntery . As a note I believe it is possible to make the add-ons update pull from Github instead of AMO as I believe that's what Bypass Paywalls did. So that is an option if you do not or cannot release it on AMO yet. And if in the next release you upload the .xpi as well on the release assets, then I'd like to remind you to update the Readme as it would be much easier than the current process.

Thanks.

Dyras commented 4 years ago

Life isn't truly complete without a Firefox version in the store.

ahmed-abdelrazek commented 4 years ago

firefox console on a youtube video https://pastebin.com/rqDTYmLm

also firefox and new edge doesn't stop the video from buffering when the autoplay is disabled

cyangalaxy commented 3 years ago

@cpuuntery Thank you for the XPI-file! It looks like it's self-signed. Can you perhaps teach us how you self-signed it? I did a little bit of research and the process looks a bit complicated. I may be able to figure it out with a bit of time-investment, but maybe you can help me out? I can't write you directly, so I'm replying here. Recently switched to Firefox and don't wanna miss this awesome extension.

chrisspiegl commented 3 years ago

Hello everybody, I just am exploring my path to switching to Firefox and would love to see this extension supported fully. Would it be possible for the developers to publish an official XIP extension to Github in the releases?

I tried sideloading the extension temporarily but that's not really a solution and downloading an XIP from someone's DropBox and self-signing and stuff… I would prefer not to do that.

A few things I noticed:

I'm happy to test more and help getting this ready — even if just as an official XIP download for the website / github releases.

Looking forward to getting this out there.

cyangalaxy commented 3 years ago

@chrisspiegl You can fully install the latest version of ImprovedTube on Firefox Developer Edition:

You need to first allow unsigned XPIs. Go to about:config and set xpinstall.signatures.required to false. Then download the latest ImprovedTube ZIP from GitHub, extract manifest.json and open it in a Text editor: Add this:

    "browser_specific_settings": {
      "gecko": {
        "id": "improvedtube@tomxyz1"
      }
    },

This is how it should look like: https://imgur.com/a/FdKO6nx (It doesn't need to be "tomxyz1")

Put the modified manifest.json back into the ZIP and replace the original. Drag the ZIP onto Firefox with about:addons open. That's it.

So basically, you only need Firefox Dev with disabled Signature-Verification, and the extension as a ZIP/XPI with a modified manifest.json

By the way, Firefox Developer Edition is just Firefox Beta with added developer tools, it doesn't take up more space than the other versions, so it's a completely stable and usable version of Firefox.

ahmed-abdelrazek commented 3 years ago

@tomxyz1 not everyone use want or need Firefox developer edition but thanks i going to try this

cyangalaxy commented 3 years ago

@ahmed-abdelrazek I know, I know, but this is the only way you can install an unsigned extension like ImprovedTube.

Regardless, Firefox Dev isn't unstable. I'm sure you'll be fine using the Developer Edition. I use it for some months now after transitioning from Chrome, and it's nice. It really isn't much different from the normal version.

cpuuntery commented 3 years ago

@tomxyz1 Very sorry for the late reply. You need to go to this link and sign up with email. And then you will receive an activation link on your email. And after that follow the pictures Untitled.png after that Untitled.png after that Untitled.png after that Untitled.png after that Untitled.png after that Capture.png after that Untitled.png after that Untitled.png Usually it takes about 10 minutes to sign the extension. The status will change from awaiting approval to approved. Only after that. you will click on a link in the last picture And you will also get an email from Mozilla that notify you that the extension has been signed and a link to download it. the link is the same link from the last picture Untitled.png

cyangalaxy commented 3 years ago

@cpuuntery Don't worry. Thank you very much for the step by step instructions, that looks really easy!

cpuuntery commented 3 years ago

@tomxyz1 thanks and one last thing You can also follow these instructions to disable signature checking on Firefox stable stackoverflow instructions! OR superuser instructions!

cyangalaxy commented 3 years ago

@cpuuntery It didn't get approved.. https://imgur.com/a/N67c3U2 I did the exact steps

cpuuntery commented 3 years ago

@tomxyz1 It is not your fault. mozilla. Just got stricter with extension submissions. In fact, in the past about late 2019 they used to sign extension Instantly and in the beginning of 2020 it would require about 10 minutes. And now they think the extension contain security risks. You need to contact and email amo-admins@mozilla.com and tell them that the extension is for self distribution so it is not a security risk, and then they will sign the extension for you

dubra15 commented 3 years ago

Thanks

El mié., 2 de diciembre de 2020 5:20 a. m., cpuuntery < notifications@github.com> escribió:

@tomxyz1 https://github.com/tomxyz1 It is not your fault. mozilla. Just got stricter with extension submissions. In fact, in the past about late 2019 they used to sign extension Instantly and in the beginning of 2020 it would require about 10 minutes. And now they think the extension contain security risks. You need to contact and email amo-admins@mozilla.com and tell them that the extension is for self distribution so it is not a security risk, and then they will sign the extension for you

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ImprovedTube/YouTube/issues/440#issuecomment-737101972, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMYRWOW6TKWNQHKPDSQXRRLSSYBGXANCNFSM4PLNCOPA .

furquim87 commented 3 years ago

@cpuuntery I tried to email them, but unfortunately got no answer whatsoever.

cpuuntery commented 3 years ago

@Termuellinator @bayazidbh @Michedelic @tomxyz1 @furquim87 @dubra15 @chrisspiegl @Jinsgo I created a post on Reddit in r/firefox to be specific. And there are Mozilla Employees on the subreddit so if you have a Reddit account upvote my post and tell all your friend who are Firefox users. If we make enough buzz maybe they will revert to the old behaviour when there was no review and approval process for self distribution extensions. And if you win it will not just be a win for us, it will be a win for every person who want to install extensions outside the store for Firefox stable

tazihad commented 3 years ago

Please provide an latest xpi as beta testing. I am using above xpi you shared. Everything works except mini player. A latest xpi extension would be great.

cyangalaxy commented 3 years ago

Please provide an latest xpi as beta testing. I am using above xpi you shared. Everything works except mini player. A latest xpi extension would be great.

I can give you the latest XPI, but you'll have to have either Firefox Developer or Nightly

tazihad commented 3 years ago

Okay. Please share.

cyangalaxy commented 3 years ago

Here: https://drive.google.com/file/d/19XhTY9j9CNiLZqkav1g814xfOMxx5lcJ/view?usp=sharing You'll need Firefox Dev/Nightly, and in about:config disable xpinstall.signatures.required The extension has to be installed by dragging it into about:addons

tazihad commented 3 years ago

i have installed it. there's a bug. I can't move custom player that pops up when I browser comment.

ghost commented 3 years ago

Official Firefox support is on the way.

d4k0 commented 3 years ago

@victor-savinov That sounds really great! Is there any ETA on this?

ghost commented 3 years ago

@cpuuntery

I love your workaround, but it seemed to stop working for me for the new versions. The version I upload (3.183) doesn't seem to get automatically signed and fails the manual review. Do you know a workaround until there is an official extension?

Dyras commented 3 years ago

Never thought I'd see the day. Cheers!

platinorum commented 3 years ago

TYSM for this! I think a lot of people (including me!) have been waiting for this for a long time. Thank you for finally making it possible <3

Termuellinator commented 3 years ago

Oh yeah, i'm really excited about it, too - the old signed XPI was pretty out of date xD

ImprovedTube commented 3 years ago

what about Firefox on Android? #1002

ahmed-abdelrazek commented 3 years ago

what about Firefox on Android? #1002

use vancedtube

ImprovedTube commented 3 years ago

i mean, did any of you try or miss ImprovedTube inside Firefox inside Android?

Termuellinator commented 2 years ago

For Android i use Newpipe anyway ^^ But for the desktop, the Mozilla Store is still on version 3.223 - not that i want to sound needy or have any idea how much of a nuisance it is to update something there, but just a mention that it's not up to date ;)