code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.52k stars 533 forks source link

Player size: fit to window bug. #897

Closed 26adriano closed 3 years ago

26adriano commented 3 years ago

Bug Report:

BUG:
On loading a video, on youtube, I find that the sidebar is overloaying the video. The bug is easily fixed by manually going and reapplying the fit to window option in Apperance -> Player -> Player size.

HOW:
I find that this bug happens on every video that I open before i do the manual fix. However the bug will not show for a good time afterwards (normally the next day).

Screenshots:
When the bug happens Capture

What I expect to happen Capture2

⚬ Browser:
Firefox 88.0.1 (64-bit)

⚬ ImprovedTube Version:
3.223

⚬ Settings:
improvedtube.txt rename to .json if need-be.

⚬ OS:
Windows 10 20H2

ImprovedTube commented 3 years ago

Hey @gexysz! previously fit to window did only expand as much as possible without covering related videos. i.e. player:full window = player:fit to window + related-videos:hide

26adriano commented 3 years ago

When I used brave browser over 6 months ago, I do not think that this issue appeared (please dont quote me one that). However since the release of improved youtube on the firefox store, I have used constantly and this has always been a problem. It feels like that the 'fit to windows' is not loading properly and i have to reapply it. Also I have it set up as player:fit to window + related-videos:normal. the related videos normally sit under the video nicely, as show in the picture below. Capture

ImprovedTube commented 3 years ago

happens in chrome too when toggling theater mode, does it?

26adriano commented 3 years ago

when i was using brave I don't think that this occured

GKid94 commented 3 years ago

@ImprovedTube Same

Screenshot 2021-06-30 130940

ghost commented 3 years ago

Fixed (https://github.com/code4charity/YouTube-Extension/commit/a824349fd1e4d0b057242919cfe9d56c8b0b8ed5)