search

code-chunks / angular2-logger

A log4j inspired logger for angular 2.
MIT License
144 stars 41 forks source link

Support both Angular 4 & 5 #177

Closed mdentremont closed 6 years ago

langley-agm commented 6 years ago

Remove the version number change please, npm should handle it when making the release.

mdentremont commented 6 years ago

@langley-agm :+1:

mdentremont commented 6 years ago

@langley-agm Anything else I can do, or is it good to go?

fmpierce commented 6 years ago

I hope this gets merged soon.

langley-agm commented 6 years ago

@mdentremont an apology, I haven't had access to my pc for a while, lost my charger, I've been traveling and whatnot, if you guys have tested it and it works feel free to do the release so you don't have to wait, otherwise I have my personal laptop and charger now so I'll try my best to do it this weekend. I'll also try to make a guide on how to release so people don't have to wait for me in these scenarios. again I'm sorry !

langley-agm commented 6 years ago

Merged and published, should be good now Guys, let me know if any issues arise !

@mdentremont @fmpierce