search

code-corps / ember-stripe-service

An ember-cli addon which injects Stripe as an Ember service
MIT License
91 stars 33 forks source link

stripe terminal support #64

Open jamemackson opened 5 years ago

jamemackson commented 5 years ago

stripe terminal is slated to be out of beta within the next few months and would be great if that would be supported. I'm in the beta now and would be happy to do some legwork to add support for this.

ref: https://stripe.com/docs/terminal/js

snewcomer commented 5 years ago

@jamemackson This sounds like a great idea! Took a quick look at it and would be interested in the actual implementation and if would require another addon....

jamemackson commented 5 years ago

I've been scoping it out and I think this would be fairly easy to add into this addon. I'm actively working on a first crack at a PR to add this functionality and will push it up in the next few days which should facilitate better conversation around it (and whether this should really be it's own addon) but with lazy loading and an enableTerminal flag it shouldn't add much weight to built applications to include within this addon. There is definitely more moving parts to using a terminal vs processing a standard transaction