search

code-corps / ember-stripe-service

An ember-cli addon which injects Stripe as an Ember service
MIT License
91 stars 33 forks source link

Latest version (v7.0.0) doesn't work on Ember 3.5 #66

Open samselikoff opened 5 years ago

samselikoff commented 5 years ago

Looks like there's been some work done recently – should we cut a release?

snewcomer commented 5 years ago

@samselikoff Probably a good idea. Was waiting for this PR but perhaps we should throw up a new one - https://github.com/code-corps/ember-stripe-service/pull/63

samselikoff commented 5 years ago

Cool :)

The error I'm getting is

"Assertion Failed: You attempted to define a {{link-to "subscribe"}} but did not pass the parameters required for generating its dynamic segments. Could not find module ember imported from ember-stripe-service/services/stripe"

(The link-to part is irrelevant). I was surprised that the module import broke in 3.5 because no deprecations were thrown in 2.18 and I just asked in Discord, and was told import Ember from 'ember' is still supported. Wonder what's going on?

snewcomer commented 5 years ago

@samselikoff Is this a PR you can approve? https://github.com/code-corps/ember-stripe-service/pull/67

samselikoff commented 5 years ago

I don't have write access

snewcomer commented 5 years ago

@buritica 👋 Would it be possible to get npm rights so publish 7.1.0? Thanks a lot!

samselikoff commented 5 years ago

I also believe this is the root cause, because I'm seeing the same error on 2 other addons https://github.com/ember-cli/ember-cli/issues/8135

buritica commented 5 years ago

hi everyone.

I just published 7.1.0, please feel free to ping me anytime you do version bump so I can publish.

given the latest npm fun, and since this package remains published by me, I will hold the publishing rights for myself until @joshsmith and I can chat about the right way of transferring these rights.

sidenote, I just restored a change in the .gitignore file that would've lead me to accidentally commit my stripe private key, if we wan't to change the recommended way that people load ENV vars (we use, or used to recommend direnv, and it's the reason why .envrc.example is still in the root) then let's do that. I do apologize for sending the commit directly to master and not sending it as a PR, but considered it critical for security of other people who may fork it.

thank you!

snewcomer commented 5 years ago

Darn. I could have just asked Josh over ramen lunch an hour ago 😋. No worries though. As long as we can get a release, probably nothing to do!

samselikoff commented 5 years ago

Coming back to an upgrade and I'm hitting an issue in my test suite, not sure if it's related to this.

I believe the loadJs.then(() => call in the Stripe service isn't properly telling the test to wait, though I'm not sure what changed here between 2.x and 3.x.

Maybe we need to have the _waiter check to make sure the loadJs function has finished?

snewcomer commented 5 years ago

Anybody looking at this issue, it is still open until we can publish 7.2.0!

Also any updates on the test issue? Not sure I see any tests to verify this in the addon though.