Verifies if "reference type" parameters are null

[ElemarJR]

void Foo(Fee a)
{
}

becomes

void Foo(Fee a)
{
   if (a == null) throw new ArgumentNullException(nameof(a))
}

Style: Refactoring Severity: Hidden Id: CC0078

@clklachu is working on it.

[sharwell]

This is more or less a duplicate of https://github.com/DotNetAnalyzers/NullParameterCheckRefactoring.

[ElemarJR]

Yes. It is.

[shubheksha]

I'm a newcomer, so I'm a little lost in the codebase. I understand what is to be done, but which files need to be changed?

[giggio]

@shubhekshajalan Take a look at commit 718539eeeb757105fa58b823e93b44c3a924305f. You will see 9 changed files. You can ignore the first one, runTestsCS.ps1, that was another change that made into the commit. And actually only 3 files are created, only 2 updated, the other 3 are updated by Visual Studio.

That commit is a good example of a commit that creates an analyzer and a code fix. What is necessary:

• src/CSharp/CodeCracker/Refactoring/LoopToLinqAnalyzer.cs
  That is the analyzer file itself. This is a new file.
• src/CSharp/CodeCracker/Refactoring/LoopToLinqCodeFixProvider.cs
  That is the code fix provider. This is a new file.
• src/Common/CodeCracker.Common/DiagnosticId.cs
  This is an update to an existing file, this is where we add the diagnostic id, in this issue, the CC0078 is the diagnostic id, as you see on the issue's description.
• src/Common/CodeCracker.Common/Properties/Resources.resx
  This is a resource file used for localization, and is updated. You use the resource designer to add stuff to it, you don't need to update the xml. All text strings go into it. Stuff like the analyzer's messages, etc.
• test/CSharp/CodeCracker.Test/Refactoring/LoopToLinqTests.cs
  This is the new test file.

CodeCracker.csproj, CodeCracker.Test.csproj and Resources.Designer.cs are updated automatically by Visual Studio.

Do you want to work on this issue? We can help you if have any trouble.

[clklachu]

Hi @giggio I'm a first timer and i would like to work on this issue, Could you please assign it to me? I will get back on any doubts.

[giggio]

@clklachu go ahead.

[MhdTlb]

Is this issue still open? Can I work on it?

[carloscds]

@MhdTlb It's open, go ahead!