search

code-disaster / steamworks4j

A thin Java wrapper to access the Steamworks API
https://code-disaster.github.io/steamworks4j/
MIT License
468 stars 64 forks source link

jigsaw/module-info.java support? #101

Open chengenzhao opened 3 years ago

chengenzhao commented 3 years ago

Hi,

It would be nice to have a modular info for this project since we are using Java version 9+ to build the game many dependencies we are using have been modularized except this one

Screen Shot 2021-01-20 at 8 31 24 PM

thanks

XenoAmess commented 3 years ago

For my own opinion, I HATE jigsaw. But adding module-info.java seems no harm(to no-jigsaw users).

tlf30 commented 1 year ago

I second this, it would be great to get module support. If necessary I can help get a PR together, or help answer any questions you have on implementing it.

tlf30 commented 1 year ago

@code-disaster I am looking at putting together a PR. I have hit a major blocking issue in making a simple migration using automation module names. Shared package between steamworks4j and steamworks4j-server jars. This is an issue because JMS does not allow classes in the same package from two different modules. A solution would be to move everything in the steamworks4j-server jar into its own classpath, such as com.codedisaster.steamworks.server, but because of the use of package private (protected) access between the two jars, this is not possible. Perhaps the best solution would be to merge the two jars into a single jar.

Thoughts?

EDIT: Please see draft pr #124

bowbahdoe commented 8 months ago

Bump

Sascha-T commented 1 week ago

Bump