code-disaster / steamworks4j

A thin Java wrapper to access the Steamworks API
https://code-disaster.github.io/steamworks4j/
MIT License
479 stars 67 forks source link

SteamUGC deleteItem() not implemented #64

Closed Shadow6390 closed 6 years ago

Shadow6390 commented 6 years ago

Greetings,

I am currently developing Steam Workshop support for an application and during item creation and submission, the process can fail due several reasons. As stated on the Steamworks SDK, there is no way of canceling the process once it's done. As such, temporary junk file appear on the user's workshop due to the error caused.

One solution I found to fix this is to call DeleteItem after an unsuccessful submission. However, the SteamUGC does not seem to implement this method call. Is this intended?

Best Regards, Diogo Braga

AlrikG commented 6 years ago

No, this is a new command released with Steamworks SDK 1.41. So that has to be implemented. Try to verify that an item is valid before submitting it to steam.

Shadow6390 commented 6 years ago

Hey AlrikG,

Thank you for letting me know. I'll try to validate the call's validation state before submitting it and, if all else fails, just let the users know it's a known issue! :smile:

AlrikG commented 6 years ago

Hey @Shadow6390, I added deleteItem(). You can use my PR or just wait until @code-disaster has merged it into the master branch.

Shadow6390 commented 6 years ago

Hey AlrikG,

Thank you for the implementation! It sure comes in handy! :smiley: