code-dot-org / craft

Top-down 2D game engine for the Craft app type. See NOTICE for restrictions on use.
https://code-dot-org.github.io/craft/
Other
19 stars 11 forks source link

Minecraft | Aquatic mobs cannot be trampled in Freeplay levels #521

Closed WilliamHarmonMS closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #521 into master will increase coverage by 3.36%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage    70.4%   73.77%   +3.36%     
==========================================
  Files          43       43              
  Lines        5312     5312              
==========================================
+ Hits         3740     3919     +179     
+ Misses       1572     1393     -179
Impacted Files Coverage Δ
src/js/game/Entities/Squid.js 83.33% <100%> (+74.5%) :arrow_up:
src/js/game/Entities/Dolphin.js 81.57% <100%> (+73.24%) :arrow_up:
src/js/game/Entities/TropicalFish.js 81.08% <100%> (+72.5%) :arrow_up:
src/js/game/Entities/Salmon.js 81.08% <100%> (+72.5%) :arrow_up:
src/js/game/Entities/Cod.js 81.08% <100%> (+72.5%) :arrow_up:
src/js/game/Entities/SeaTurtle.js 82.05% <100%> (+73.94%) :arrow_up:
src/js/game/LevelMVC/LevelView.js 74.81% <0%> (+0.8%) :arrow_up:
src/js/game/Entities/IronGolem.js 82.08% <0%> (+1.49%) :arrow_up:
src/js/game/LevelMVC/LevelEntity.js 58.58% <0%> (+6.06%) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a329cb5...9be079a. Read the comment docs.

joshlory commented 5 years ago

Closing this one out — Neal is ok with the current behavior on the free-play level, and I don't think we want to special-case this behavior unless we absolutely have to.

https://codedotorg.slack.com/archives/C6MJHRTGC/p1540497483000100