code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.
https://code-dot-org.github.io/dance-party/
13 stars 12 forks source link

level 13 toolbox collapses when dragging blocks out #205

Open brook-osborne opened 5 years ago

brook-osborne commented 5 years ago

chrome, mac.

toolbox is automatically closing when i navigate into the workspace. anything i click on in the toolbox drops into the workspace on top of my existing code:

toolbox

joshlory commented 5 years ago

@ryansloan this is the default Blockly toolbox behavior when in category mode. Do we want to change it for all apps?

joshlory commented 5 years ago

@brook-osborne I think what's happening here is when you click the toolbox block and release, it's starting to drag it then immediately dropping it where your cursor is. Would you expect the block not to be created until you move the mouse a little bit?

I think the challenge is, the way is works now is:

mousedown — close the flyout and create a new block under the cursor mousemove — drag the block mouseup — drop the block

If you just click on a block (mousedown + mouseup), it closes the flyout and drops the block in one instant.

brook-osborne commented 5 years ago

i think it is a jarring behavior to see because we've just gone through 12 levels where you have to drag blocks from the toolbox to the workspace and here they are responding to just a click. i would expect the behavior to be the same on this level.

is it possible to set up the toolbox like what we have in applab when categories are in use? screen shot 2018-11-08 at 11 10 46 am

joshlory commented 5 years ago

We want that at some point, but it may be too late in the game for Hour of Code. FWIW @bakerfranke had similar feedback on the toolbox in https://github.com/code-dot-org/dance-party/issues/156#issue-378042369.

I wonder if introducing categories sooner in the progression makes it less jarring?

ghost commented 5 years ago

@ryansloan i think it's too late to make this change so moving this to the post-HOC milestone, but wanted you to see that I moved it