search

code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.
https://code-dot-org.github.io/dance-party/
13 stars 13 forks source link

Shared PG13 songs can be listened to by those < 13 #456

Open Bjvanminnen opened 5 years ago

Bjvanminnen commented 5 years ago

Not sure if this is a bug or by design.

Scenario: (1) High schooler Alice makes a dance-party app using the PG13 song Ed Sheeran (2) Alice shares that app with her elementary school brother Bob who is signed in and under 13

Result: Bob can view the share and listen to the scandalous stylings of Ed Sheeran. When Bob clicks "How it works", he's taking to the /view page and can again listen to Ed Sheeran. However, we've moved Ed from the dropdown here, so the dropdown claims Bob is listening to Ace of Base image Bob can also remix the app, where he now has his own app with Ed Sheeran, though the dropdown will continue to claim that it's Ace of Base.

ryansloan commented 5 years ago

The first part (I, an under-13 student, can listen to the Scandalous Stylings of Sheeran on the share page) is by design. The second, that the dropdown shows the wrong thing if I go into view or remix mode is weird, and is a bug, but not one we'll fix before HOC.

simplycloud commented 5 years ago

what should we show here? should we have a "none" option shown for the song or something like that?