search

code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.
https://code-dot-org.github.io/dance-party/
13 stars 12 forks source link

get bass/treble block doesn't work #457

Open Bjvanminnen opened 5 years ago

Bjvanminnen commented 5 years ago

image

This translates into code getEnergy("low"). Treble translates into code getEnergy("high"). Instead they should be getEnergy("bass") and getEnergy("treble").

Mid works correctly

Bjvanminnen commented 5 years ago

I might just cut this block, as afaict we don't really use it anywhere and it's not entirely clear how one would use it (i.e. I think you'd need to know it returns values in the range of (0, 256) and even then it's not trivial to use it).

ryansloan commented 5 years ago

I removed these from the toolboxes for now (they aren't required, as Brent mentioned), and am moving this issue tracking the block changes to post-HOC