search

code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.
https://code-dot-org.github.io/dance-party/
13 stars 13 forks source link

[Low pri] I get the animation error message even if I don't press the download animation button #487

Open poorvasingal opened 5 years ago

poorvasingal commented 5 years ago

image

Low pri b/c it requires me to be on the share dialog for 30 seconds. The reason the animation didn't work is because I didn't hit the "Run" button. (In the future, may be better to just remove the download animation button altogether if the project hasn't been run).

Erin007 commented 5 years ago

I think fixing #517 will also resolve this issue, because if we stop the 403 errors that are occurring even before the download animation button is clicked, we'll never show the "sorry, we were unable to download..." message regardless of how long the dialog is open. @Hamms does that sound correct to you?

poorvasingal commented 5 years ago

Oooh, are we planning on making the fix so we don't do the call until we hit the Download animation button? I think that's great. And yeah, that should solve this error.

Hamms commented 5 years ago

517 is unrelated; we definitely want to start checking for the video before clicking the download button. We just need to update when the DownloadReplayVideo component calls its onError method to only do so if the button has been clicked

Erin007 commented 5 years ago

https://github.com/code-dot-org/code-dot-org/pull/26268

simplycloud commented 5 years ago

moving to post-HOC in case there is further work we want to do here.