search

code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.
https://code-dot-org.github.io/dance-party/
13 stars 13 forks source link

dancer variables disappear when creating new ones #491

Open davidsbailey opened 5 years ago

davidsbailey commented 5 years ago

repro steps:

  1. go to https://studio.code.org/projects/dance/new
  2. click "dancer1" on the first block. see these options: dancer1, dancer2, dancer3, this_sprite, Rename variable..., New variable...
  3. click New variable...
  4. type in bob as the new name
  5. click bob on the first block

expected options: bob, dancer1, dancer2, dancer3, this_sprite, Rename variable..., New variable... actual options: bob, dancer2, dancer3, this_sprite, Rename variable..., New variable...

it appears that dancer1 has incorrectly disappeared from the variable list.

simplycloud commented 5 years ago

added to CSED milestone, but will confirm with @ryansloan if he thinks we should fix or push out to post-HOC. @davidsbailey any thoughts on how complicated this is to resolve?

davidsbailey commented 5 years ago

poking around a bit more, it appears that we don't really store a list of variables anywhere, we just display the list of whatever dancer names are currently selected in any blocks in the workspace. so, i'm not sure there's a quick fix for this. So I'm going to move this to post-HoC.

I'm also seeing a related issue, with the wrong thing being shown in the dropdown after performing New variable.... I've opened https://github.com/code-dot-org/dance-party/issues/511 for this, also post-HoC.

ryansloan commented 5 years ago

👍 to post hoc. This is true of all our variable dropdowns, I think?