code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.
https://code-dot-org.github.io/dance-party/
13 stars 13 forks source link

Add setPropRandomEach to Dance API #575

Closed epeach closed 5 years ago

epeach commented 5 years ago

Per this spec: https://docs.google.com/document/d/1MJzshSBGHx4azMgyJSfmuYll77T8HHodQFMsY_4Pp3w/edit#heading=h.nxq7k4gyikj This issue: https://github.com/code-dot-org/dance-party/issues/183 With test

codecov-io commented 5 years ago

Codecov Report

Merging #575 into master will increase coverage by 0.07%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage   34.59%   34.67%   +0.07%     
==========================================
  Files          23       23              
  Lines        3451     3455       +4     
==========================================
+ Hits         1194     1198       +4     
  Misses       2257     2257
Impacted Files Coverage Δ
src/api.js 39.58% <0%> (-0.85%) :arrow_down:
src/p5.dance.js 85.88% <100%> (+0.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 544b0db...920f642. Read the comment docs.