search

code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.
https://code-dot-org.github.io/dance-party/
13 stars 13 forks source link

Use the same asset version used in the cdo repo #581

Closed epeach closed 5 years ago

epeach commented 5 years ago

The CDO repository uses the https://curriculum.code.org/images/sprites/dance_20181127/ folder for assets. Let's update the default version in dance party to point at the same direction.

https://github.com/code-dot-org/code-dot-org/blob/staging/apps/src/dance/Dance.js#L401

Part of work to close the loop on sprites and de-duplicate spritesheet.

codecov-io commented 5 years ago

Codecov Report

Merging #581 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   31.89%   31.89%           
=======================================
  Files          27       27           
  Lines        3800     3800           
=======================================
  Hits         1212     1212           
  Misses       2588     2588
Impacted Files Coverage Δ
src/ResourceLoader.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25da1d9...556476f. Read the comment docs.