search

code-dot-org / dance-party

Renderer for the Dance game type. Based on p5.js and p5.play.js.
https://code-dot-org.github.io/dance-party/
13 stars 13 forks source link

hoc2023: prettier JS files #647

Closed breville closed 1 year ago

breville commented 1 year ago

This updates the formatting of all JS files in this repo, in preparation for additional updates for hoc2023.

breville commented 1 year ago

Thanks for prepping for the upcoming changes. I am curious - were you able to make all the 'prettier' changes automatically? I see you added the configuration to .prettierrc.js after you made the file updates.

I applied these in an editor, one file at a time, but presumably there is a way to do this by batch in the command line. I had the prettierrc.js file there the whole time, but didn't commit it until later.

fisher-alice commented 1 year ago

Thanks for prepping for the upcoming changes. I am curious - were you able to make all the 'prettier' changes automatically? I see you added the configuration to .prettierrc.js after you made the file updates.

I applied these in an editor, one file at a time, but presumably there is a way to do this by batch in the command line. I had the prettierrc.js file there the whole time, but didn't commit it until later.

Oh gotcha - thanks!

fisher-alice commented 1 year ago

General question - will we bump up the version after all the hoc updates?

breville commented 1 year ago

General question - will we bump up the version after all the hoc updates?

We will bump the version each time we have a new build that we want to be consumed by our main repo, which I think should be done regularly once we have momentum.

breville commented 1 year ago

I went ahead and did the other JS files in the repo too.