Closed bencodeorg closed 11 months ago
Making a couple more changes here, will re-request review when they're done!
Left a couple questions. Also curious if you were going to use the more modern syntax as @sanchitmalhotra126 had mentioned from #672 (review).
@fisher-alice re: modernizing syntax, I couldn't quite figure out why import statements aren't working, and it felt like work that could be picked up separately (maybe in conjunction with the "move effect definitions from object syntax to class syntax"?)
Left a couple questions. Also curious if you were going to use the more modern syntax as @sanchitmalhotra126 had mentioned from #672 (review).
@fisher-alice re: modernizing syntax, I couldn't quite figure out why import statements aren't working, and it felt like work that could be picked up separately (maybe in conjunction with the "move effect definitions from object syntax to class syntax"?)
Sounds reasonable to me!
A proposed follow-up to https://github.com/code-dot-org/dance-party/pull/672 -- there is very little shared between background and foreground effects, so we could potentially totally separate them.
Some pros and cons I considered while putting this together -- I'm leaning towards this feeling like a good idea, but could be dissuaded :):
Pros:
Cons: