search

code-dot-org / ml-activities

This is the repo for AI for Oceans from Code.org.
https://code-dot-org.github.io/ml-activities/
Apache License 2.0
5 stars 7 forks source link

Migrate to GitHub Actions #381

Closed aaronwaggener closed 3 years ago

aaronwaggener commented 3 years ago

Follow-up from https://github.com/code-dot-org/ml-activities/pull/378

Replaces TravisCI with Github Actions. I created a Build action for PRs and a Deploy one for merges. The Deploy action essentially runs through the same build steps and then has an extra "action" to deploy to GitHub Pages.

I also went ahead and moved this repo to node v14 to match the code-dot-org app. And I had to bump the canvas package up to one with an available linux binary (downloads during yarn install).

aaronwaggener commented 3 years ago

@madelynkasula ready for another review. Let me know if you think we should go a different direction with the naming and/or conditional deploy step.

aaronwaggener commented 3 years ago

most of our island repos don't deploy on merge (we manually publish an NPM package) -- i wonder if we should move toward having those repos automatically publish when we merge into main 🤔

@madelynkasula I was thinking about something along the same lines. The flow I had in mind was to still have a developer use npm version and the script in package.json would be a simple git tag and push. Then we have a workflow that will get triggered when a new tag is seen and it would kick off a build and publish from main. By triggering on tag there is still some intentionality from a developer to publish a new version and for them to choose what version we are bumping to. I would love to explore this further next time we have changes to a package we are publishing.