search

code-for-chapel-hill / NC-COVID-Support

Community support site, supporting COVID-19 business opening hours, Food Banks, School Meals, Farms and Social Services.
https://nccovidsupport.org
GNU General Public License v3.0
16 stars 39 forks source link

Make the About Us dialog full screen on tablet and mobile. #116

Closed readingdancer closed 4 years ago

readingdancer commented 4 years ago

Have an idea for an additional feature? (a) Describe the feature When the About Us dialog pops up on mobile I would like it to be full screen as being in a "dialog" it is wasting valuable space. With some simple CSS we can change the dialog on mobile to fill the screen and also hide the close cross ( we don't need two ways to close the dialog on mobile, not sure we need two on desktop tbh. )

This is what it currently looks like:

About Us Mobile

(b) How does it need to perform?

You shouldn't see any of the background on the surrounding margins on mobile and tablet, on Desktop it should work as it does currently.

(c) How will we code it?

Just by changing the mobile CSS which should be over written by the desktop CSS.

readingdancer commented 4 years ago

This has been fixed by @dsummersl , thank you again :)

readingdancer commented 4 years ago

@all-contributors add @dsummersl with code

allcontributors[bot] commented 4 years ago

@readingdancer

File README.md was not found in the repository (code-for-chapel-hill/NC-COVID-Support).

readingdancer commented 4 years ago

Trying again :)

@all-contributors add @dsummersl with code

allcontributors[bot] commented 4 years ago

@readingdancer

File docs/README.md was not found in the repository (code-for-chapel-hill/NC-COVID-Support).

readingdancer commented 4 years ago

And again...

@all-contributors add @dsummersl with code

allcontributors[bot] commented 4 years ago

@readingdancer

I've put up a pull request to add @dsummersl! :tada: