code-for-chapel-hill / NC-COVID-Support

Community support site, supporting COVID-19 business opening hours, Food Banks, School Meals, Farms and Social Services.
https://nccovidsupport.org
GNU General Public License v3.0
16 stars 39 forks source link

Enable a list view for resources #253

Closed glitchedmob closed 4 years ago

glitchedmob commented 4 years ago

Fixes #242

Co-authored-by: Fred Lawler fred@fredlawl.com Co-authored-by: Levi Zitting me@levizitting.com

ghost commented 4 years ago

Hey there! :wave: This repository uses the Prettier code style.

You forgot to format these files in your pull request:

The Prettier installation guide is a good place to get started with formatting your code properly. Thanks!!

:heart:

Your friendly Prettifier bot

glitchedmob commented 4 years ago

@readingdancer

  1. Fixed. The listing/detail should come up from the bottom now.
  2. Fixed this as well. The whole map was being pushed way down. That doesn't happen anymore.
  3. I've updated that button to say Show Resource Details if the detail view is open. I agree with your idea of showing a mini business profile there instead but I think that's best done in another PR. This one is already getting pretty big and it's somewhat holding up other progress
readingdancer commented 4 years ago

Thank you @glitchedmob and @fredlawl for your work on the PR, now to create some more issue ticket to solve the rest of the little issues :)