search

code-for-chapel-hill / NC-COVID-Support

Community support site, supporting COVID-19 business opening hours, Food Banks, School Meals, Farms and Social Services.
https://nccovidsupport.org
GNU General Public License v3.0
16 stars 39 forks source link

Change b-form-select to b-dropdown #267

Open aevix opened 4 years ago

aevix commented 4 years ago

In the file SearchFilter.vue the b-form-select uses options tag to render the dropdown menu so I tried just changing the css cursor option to pointer but didn't seem to work so I found out that the options tag is rendered using the user OS so that's why on the screen shots of mac and windows dropdown menus looks different. I did some digging and found out b-dropdown allows me to not only change the cursor to pointer but also makes sure that the dropdown menu is the same on all platforms. I managed to get it to work with all the buttons but there maybe some unforeseen bugs and probably needs adjustment to make it look the way you want it in styling. Fixes #209 Let me know what you think and if this could be a solution to issue209

ghost commented 4 years ago

Hey there! :wave: This repository uses the Prettier code style.

You forgot to format these files in your pull request:

The Prettier installation guide is a good place to get started with formatting your code properly. Thanks!!

:heart:

Your friendly Prettifier bot

readingdancer commented 4 years ago

Hi @aevix - Could you let me know why you have submitted this PR? I.e. what was the reason for the change?

( Thanks for submitting it.. I just wanted to understand the reason for it )

aevix commented 4 years ago

@readingdancer I am sorry it wasn't clear what it was for. I submitted this for issue 209 where the mouse cursor doesn't change to pointer when you mouse over the drop down options and it was because the options tag is rendered through the operating system not the client browser so I changed the tag and it was able to change it to a pointer. One problem with this is that it changed the way the dropdown menu is styled so I don't know if you wanted to use it but I figured I would create a PR just so you can see the difference.

readingdancer commented 3 years ago

I am trying to bring this project back to live as I rather dropped the ball last summer and no one else seemed to be interested to catch it. I am going to see if I can get the current PR's either merged in or closed so we have a clean slate, hence my updating the PR's now and I will start looking at them tomorrow.