search

code-for-chapel-hill / NC-COVID-Support

Community support site, supporting COVID-19 business opening hours, Food Banks, School Meals, Farms and Social Services.
https://nccovidsupport.org
GNU General Public License v3.0
16 stars 39 forks source link

Show only three buttons on mobile #282

Open jklafka opened 4 years ago

jklafka commented 4 years ago

Re: issue #259, I worked on the first part of this. On the mobile webpage, only the options to call the location, get directions or go to the website (if available) will show.

ghost commented 4 years ago

Hey there! :wave: This repository uses the Prettier code style.

You forgot to format these files in your pull request:

The Prettier installation guide is a good place to get started with formatting your code properly. Thanks!!

:heart:

Your friendly Prettifier bot

readingdancer commented 3 years ago

Hi @jklafka - Thank you for trying to take a look at this, unfortunately this is not quite what we have envisaged. We do want all the details to be viewable when a user pulls the card up from the bottom of the screen, so we don't actually want to hide the items on mobile.

If it's ok, I suggest we close this PR.

If you'd still like to try and help tackle it, perhaps we could have a call next week to discuss it?

jklafka commented 3 years ago

Sure, I'd be happy to talk about how to move forward on this next week. Do you have time next weekend to discuss it? And would you still like me to close this pull request?

readingdancer commented 3 years ago

Hi @jklafka - Really sorry that this was not followed up back in September of last year, I was a bit overwhelmed with homeschooling two children and life in general that this project got sidelined by me and no one else too over the reigns. I am trying to bring it back to life, so I will try and take a look at your PR this week, however it may well be too conflicting with the other changes to merge in, we will have to see :)

jklafka commented 3 years ago

Absolutely, no problem. To be honest, I'm not familiar with Vue.js, so worries if you have to throw the PR out! Hope you can get back into this project soon.