search

code-for-charlottesville / housinghub

GNU General Public License v3.0
14 stars 23 forks source link

Search component #79

Closed ramkarri7 closed 4 years ago

ramkarri7 commented 4 years ago

searchcomponent.js is the new sidebar search component, should be wired up. Double checking is still appreciated!

thinkharderdev commented 4 years ago

Hey @ramkarri7 I pushed a commit to fix the front-end tests.

The gist is that when you update something you have to update the Jest snapshots as well. When you run the tests nom run test and they fail it will prompt you to update the snapshots:

Snapshot Summary
 › 4 snapshots failed from 1 test suite. Inspect your code changes or press `u` to update them.

First make sure that the snapshots should be updated and this isn't a legit test failure. If that is the case you can just hit u and Jest will automatically update the existing snapshots and run the tests again.

Assuming everything passes after running the updated tests, you can commit the updated snapshot file and you should be good to go.