search

code-for-dc-edu / school-chooser

School choice web app from the genial hackers of Code for DC.
http://codefordc.org
10 stars 6 forks source link

Tts etl #43

Closed HarlanH closed 10 years ago

HarlanH commented 10 years ago

Creating a pull request to do code review... cc @Gimperion

(not sure when I'll have time to do the code review...!)

Gimperion commented 10 years ago

You mean I get to abuse for loops in R!?

There's a slight data-side issue on our end where schools that merge may have two different MGP scores during a year. This results in a rather nasty bug where if you do any type of key-matching, you'll get a naming conflict. Using a for-loop will return the first chronological entry. We're trying to get the student level data to reverse engineer the merge as to get it down to one data chunk but until then... I'm not sure what the best solution to the MGP-key issue is.

HarlanH commented 10 years ago

OK. For our app, if a school next year is a merge of two schools from last year, all bets should be off in terms of the rankings. So I'd say we should do whatever is easy to implement and won't cause a crash, then iterate as necessary later on...

On Thu, Feb 13, 2014 at 10:25 PM, Tommy Shen notifications@github.comwrote:

You mean I get to abuse for loops in R!?

There's a slight data-side issue on our end where schools that merge may have two different MGP scores during a year. This results in a rather nasty bug where if you do any type of key-matching, you'll get a naming conflict. Using a for-loop will return the first chronological entry. We're trying to get the student level data to reverse engineer the merge as to get it down to one data chunk but until then... I'm not sure what the best solution to the MGP-key issue is.

Reply to this email directly or view it on GitHubhttps://github.com/code-for-dc-edu/school-chooser/pull/43#issuecomment-35052396 .

HarlanH commented 10 years ago

OK, I tested, found one thing that seemed to need doing (filter out schools with no profiles available), and will merge this now!