search

code-for-nashville / inclucivics

Data visualization of Nashville Metropolitan Government employee salary and demographics
http://www.codefornashville.org/inclucivics/
MIT License
12 stars 18 forks source link

Feature/recharts sparkline #124

Closed kevinahuber closed 7 years ago

kevinahuber commented 7 years ago

This switches the sparkline over to recharts (re #122) as an example. I think this would be a good time to revisit what charts produce the most meaning- this is more an implementation example. The tooltip is a little gnarly and needs some work.

I used recharts area: http://recharts.org/#/en-US/api/Area

mshenfield commented 7 years ago

Looks good! Thanks for putting this together.

Right now the tooltip covers up the cursor when hovering over a point. It doesn't seem to be configurable, so not something that has to be fixed to land, but :+1: if you can figure out how to get it to play nicer.

screen shot 2017-06-10 at 10 41 17 am
mshenfield commented 7 years ago

@kevinahuber 🏓

kevinahuber commented 7 years ago

@mshenfield Sorry, holding off on this since the area charts will replace it.

kwelch commented 7 years ago

If you are looking to do charts I recommend, Victory

Not sure if it does the needs for this since I have not seen the current charts.

mshenfield commented 7 years ago

@kwelch Do you have preference, Victory vs Recharts?

kwelch commented 7 years ago

Honestly, I haven't used either. I know the team behind Victory and they are awesome. Looking at the GH for each. They seem to pretty even between the two. Rechart has more usage stats. Either choice looks really solid.