search

code-for-nashville / inclucivics

Data visualization of Nashville Metropolitan Government employee salary and demographics
http://www.codefornashville.org/inclucivics/
MIT License
11 stars 18 forks source link

Make sure departments aren't so sensitive to column names #188

Closed combinatorist closed 3 years ago

combinatorist commented 3 years ago

We noticed this when the Community Oversight Board was added: https://github.com/code-for-nashville/inclucivics/pull/181#pullrequestreview-489173520

I think it wasn't from @kazshak's changes in that PR above. I bet it was because the import script was always fragile about the field names (which the city changes a lot): https://github.com/code-for-nashville/inclucivics/blob/master/scripts/data-import.js#L93

combinatorist commented 3 years ago

Ideally, we'd make sure none of the column references are fragile, not just Departments.

kazshak commented 3 years ago

Created pull request #191 to address this issue.

combinatorist commented 3 years ago

Yeah, that worked - thanks, @kazshak!